Nate Fischer

Results 340 comments of Nate Fischer

ShellJS is designed to operate on environmental variables, which are global state. I glanced at https://nodejs.org/api/worker_threads.html#class-worker, but unfortunately it looks like this doesn't allow code in workers to modify global...

Issue #1132 also points out: > The current implementation of cd.js is swallowing the actual error. The exception caught in line 27 (e) is not logged nor used further in...

It looks like there's a CI bug on the `main` branch (not a problem with your PR). I opened issue #1130 to work on that.

I didn't get around to writing a full migration guide. If you would be interested in contributing one, then the changelog (https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md#v080-2018-01-12) would be a good starting point.

Try using `shell.find('...')` instead of `shell.exec('find ...')`. `shell.exec()` just executes a binary in the default shell; on Windows this would execute the Windows `find` command (if such a command can...

The callback is only available for `shell.exec()`. The other ShellJS methods (like `shell.find()`) return their results synchronously. I think you want something like: ```js shell.cd(path); var results = shell.find(file); //...

What is starknet-deploy? Are you able to reproduce this with a simpler command, like `echo foo` or `echo -e "foo\nbar"`?

Also: what is the output of `npx hardhat starknet-deploy > file.txt; cat file.txt`? Sometimes commands behave differently if they're printing to console (TTY). Redirecting the output into a file and...

Look similar to (but not exactly the same as) https://github.com/shelljs/shelljs/issues/1092. Should probably fix both at the same time.

I think `--silent` works as intended in your example. All this flag does is it tells shx to suppress error output, and that's what happened (shx did not print the...