shelljs icon indicating copy to clipboard operation
shelljs copied to clipboard

Added verbosity flag (-v) for cp, mv and rm commands

Open nicky1038 opened this issue 2 years ago • 3 comments

Closes #1127

The suggested verbose output is not claimed to be fully identical to the corresponding output in the original commands from coreutils. Though it is very similar, I also tried to make as few edits as possible.

nicky1038 avatar Aug 23 '23 17:08 nicky1038

I had to force-push the same commit, because I've signed it, so that GitLab could unblock the PR. No code changed

nicky1038 avatar Aug 23 '23 21:08 nicky1038

Codecov Report

Patch coverage: 55.17% and project coverage change: -0.83% :warning:

Comparison is base (a3a7e74) 97.19% compared to head (1e3df2a) 96.36%. Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1129      +/-   ##
==========================================
- Coverage   97.19%   96.36%   -0.83%     
==========================================
  Files          36       36              
  Lines        1354     1375      +21     
==========================================
+ Hits         1316     1325       +9     
- Misses         38       50      +12     
Files Changed Coverage Δ
shell.js 69.23% <20.00%> (-30.77%) :arrow_down:
src/cp.js 90.29% <50.00%> (-1.24%) :arrow_down:
src/mv.js 95.74% <50.00%> (-2.04%) :arrow_down:
src/rm.js 91.02% <66.66%> (-5.99%) :arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 28 '23 21:08 codecov[bot]

It looks like there's a CI bug on the main branch (not a problem with your PR). I opened issue #1130 to work on that.

nfischer avatar Aug 28 '23 22:08 nfischer