Nate Fischer

Results 340 comments of Nate Fischer

FWIW I think we implement this correctly. We translate `$0` to `process.argv[1]`, which is the path to the script file. Note that `process.argv[0]` is the path to NodeJS itself. Closing...

I think `$0` is right as-is, but I might accept a PR for `BASH_SOURCE`, if you know how to implement all the entries and can point to docs. Renaming this...

Do simpler functions work? How about: ```sh function sayHello { echo "hello" return 0 } ``` --- This is probably because we don't support `&&` and `||` yet (issue #19)....

> If I get some time I will take a look at what's required to add && and ||. Cool! I'll post some thoughts on #19. > Is there a...

Is this what you mean? ``` $ help shift shift: shift [n] Shift positional parameters. Rename the positional parameters $N+1,$N+2 ... to $1,$2 ... If N is not given, it...

> various shell variables *Shell* variables (values set specifically by the shell itself but not exported) probably won't work. Not sure if it makes sense to implement them in ShellJS...

@Brassrat can you link to docs for each of these?

> BTW which grammar syntax are you using ? It's PEG. We use the Ohm library: https://github.com/harc/ohm, https://ohmlang.github.io/ > Seems it will fail if when calling a command which name...

Hmm looks like it's crashing inside the glob module. Unfortunately I would need some help debugging this since I don't regularly use Windows.

Add docs? How do users figure out what value they need for SPACESHIP_BATTERY_NAME?