Nicolas Fantoni

Results 13 comments of Nicolas Fantoni

hi @karenhchu , is there something wrong with the PR that I can correct? This is my first PR and I am scared of making some errors. Thank you

@karenhchu don't worry. i absolutely don't want to rush you! Thank you very much for your reply!

Hi @karenhchu ! Thanks for the review! I think i solved every things. the plugin page was updated after my pr and is not aligned. I hope now is ok....

> LGTM. We may need another approval since the PR is so large -- @scottrigby is this something you can take a look at? I'm sorry. I promise the next...

> I didn't notice the DCO issue. > > ``` > Commit sha: [474b475](https://github.com/helm/helm-www/pull/1602/commits/474b47570de110d235deb038604a12e51a319d8a), Author: Nicolas Fantoni, Committer: Nicolas Fantoni; The sign-off is missing. > ``` I'm sorry. I've fixed...

> * netlify/helm-merge/deploy-preview Hi @TerryHowe , I've done the exclusion.

> /lgtm Hi @TerryHowe, I'll keep my branch aligned with main, okay?

> Hi @nfantoni , thanks very much for your work on this. > > Would you be willing to re-open this PR against the [hip-0024-helm4-site-upgrade](https://github.com/helm/helm-www/tree/hip-0024-helm4-site-upgrade) feature branch? > > For...

> > > Hi @nfantoni , thanks very much for your work on this. > > > Would you be willing to re-open this PR against the [hip-0024-helm4-site-upgrade](https://github.com/helm/helm-www/tree/hip-0024-helm4-site-upgrade) feature branch?...

hi @paigecalvert , I've open new PR #1857 starting from main branch after merge new version. We can close this and work on the other for a clear situation. @karenhchu...