helm-www icon indicating copy to clipboard operation
helm-www copied to clipboard

Translate topic section in italian language

Open nfantoni opened this issue 1 year ago • 5 comments

This pull request contain an italian translation for the topic section of the helm site. Let me know if something is missing or there are any errors. Thank you

nfantoni avatar Jul 09 '24 09:07 nfantoni

hi @karenhchu ,

is there something wrong with the PR that I can correct? This is my first PR and I am scared of making some errors.

Thank you

nfantoni avatar Jan 07 '25 18:01 nfantoni

@nfantoni thanks for surfacing this again and for your patience! I'll try my best to review this by EOW. Please ping me again if I don't get to it.

karenhchu avatar Jan 07 '25 18:01 karenhchu

@karenhchu don't worry. i absolutely don't want to rush you! Thank you very much for your reply!

nfantoni avatar Jan 07 '25 18:01 nfantoni

Hi @karenhchu ! Thanks for the review! I think i solved every things. the plugin page was updated after my pr and is not aligned. I hope now is ok. Let me now if need other!

nfantoni avatar Jan 15 '25 15:01 nfantoni

LGTM. We may need another approval since the PR is so large -- @scottrigby is this something you can take a look at?

I'm sorry. I promise the next ones will be smaller

nfantoni avatar Jan 27 '25 11:01 nfantoni

Hey apologies for missing this. I will review after the Helm 4 pre-release freeze in August ⏳

scottrigby avatar Jul 10 '25 20:07 scottrigby

I didn't notice the DCO issue.

Commit sha: [474b475](https://github.com/helm/helm-www/pull/1602/commits/474b47570de110d235deb038604a12e51a319d8a), Author: Nicolas Fantoni, Committer: Nicolas Fantoni; The sign-off is missing.

TerryHowe avatar Sep 09 '25 14:09 TerryHowe

I didn't notice the DCO issue.

Commit sha: [474b475](https://github.com/helm/helm-www/pull/1602/commits/474b47570de110d235deb038604a12e51a319d8a), Author: Nicolas Fantoni, Committer: Nicolas Fantoni; The sign-off is missing.

I'm sorry. I've fixed the copilot suggestion because it was right and i forget to sign commit. Now it's ok! Sorry again and thanks for the review!

nfantoni avatar Sep 09 '25 14:09 nfantoni

Need to add ignore to .typos.toml

TerryHowe avatar Oct 17 '25 11:10 TerryHowe

After that, I think we can get this merged pretty quickly, thanks for your patience

TerryHowe avatar Oct 17 '25 11:10 TerryHowe

  • netlify/helm-merge/deploy-preview

Hi @TerryHowe , I've done the exclusion.

nfantoni avatar Oct 17 '25 12:10 nfantoni

/lgtm

Hi @TerryHowe, I'll keep my branch aligned with main, okay?

nfantoni avatar Oct 21 '25 12:10 nfantoni

Hi @nfantoni , thanks very much for your work on this.

Would you be willing to re-open this PR against the hip-0024-helm4-site-upgrade feature branch?

For context, we are moving the Helm docs site over to a new framework called Docusaurus, where i18n/translations are handled a bit differently than they were with Hugo. This means that the changes you propose in this PR won't work in the new framework (for example, Docusaurus uses different json files for translating site elements instead of toml).

So, if you're up for it, could you follow the steps in https://github.com/paigecalvert/helm-www/blob/e47e82ebcc1a75bbb011825044b9135f63a0e018/versioned_docs/version-3/community/localization.md to add the it locale? It'll be similar content-wise; mainly just the implementation details that differ. Note that you'll need to run yarn or npm install first. For an example, you can see this recent PR to initialize polish localization: https://github.com/helm/helm-www/pull/1818

paigecalvert avatar Oct 24 '25 15:10 paigecalvert

Hi @nfantoni , thanks very much for your work on this.

Would you be willing to re-open this PR against the hip-0024-helm4-site-upgrade feature branch?

For context, we are moving the Helm docs site over to a new framework called Docusaurus, where i18n/translations are handled a bit differently than they were with Hugo. This means that the changes you propose in this PR won't work in the new framework (for example, Docusaurus uses different json files for translating site elements instead of toml).

So, if you're up for it, could you follow the steps in https://github.com/paigecalvert/helm-www/blob/e47e82ebcc1a75bbb011825044b9135f63a0e018/versioned_docs/version-3/community/localization.md to add the it locale? It'll be similar content-wise; mainly just the implementation details that differ. Note that you'll need to run yarn or npm install first. For an example, you can see this recent PR to initialize polish localization: #1818

Hi @paigecalvert ,

you prefer that i open the pr versus that branch and fix the difference or that i open a new branch, add content and then open the pr?

nfantoni avatar Oct 24 '25 16:10 nfantoni

Hi @nfantoni , thanks very much for your work on this. Would you be willing to re-open this PR against the hip-0024-helm4-site-upgrade feature branch? For context, we are moving the Helm docs site over to a new framework called Docusaurus, where i18n/translations are handled a bit differently than they were with Hugo. This means that the changes you propose in this PR won't work in the new framework (for example, Docusaurus uses different json files for translating site elements instead of toml). So, if you're up for it, could you follow the steps in https://github.com/paigecalvert/helm-www/blob/e47e82ebcc1a75bbb011825044b9135f63a0e018/versioned_docs/version-3/community/localization.md to add the it locale? It'll be similar content-wise; mainly just the implementation details that differ. Note that you'll need to run yarn or npm install first. For an example, you can see this recent PR to initialize polish localization: #1818

Hi @paigecalvert ,

you prefer that i open the pr versus that branch and fix the difference or that i open a new branch, add content and then open the pr?

Totally up to you @nfantoni , whatever is easier. Here's the link to update the base branch of a PR, or making a new one is also fine

I'll also actually throw out one more option, which is that you can wait until next week to make these changes. We are planning to merge the hip-0024-helm4-site-upgrade feature branch on early next week (hopefully Monday or Tuesday), which will update the site to use Docusaurus. At that point, since main will be updated to docusaurus, this PR could just be refactored and then merged to main.

paigecalvert avatar Oct 24 '25 17:10 paigecalvert

Hi @nfantoni , thanks very much for your work on this. Would you be willing to re-open this PR against the hip-0024-helm4-site-upgrade feature branch? For context, we are moving the Helm docs site over to a new framework called Docusaurus, where i18n/translations are handled a bit differently than they were with Hugo. This means that the changes you propose in this PR won't work in the new framework (for example, Docusaurus uses different json files for translating site elements instead of toml). So, if you're up for it, could you follow the steps in https://github.com/paigecalvert/helm-www/blob/e47e82ebcc1a75bbb011825044b9135f63a0e018/versioned_docs/version-3/community/localization.md to add the it locale? It'll be similar content-wise; mainly just the implementation details that differ. Note that you'll need to run yarn or npm install first. For an example, you can see this recent PR to initialize polish localization: #1818

Hi @paigecalvert , you prefer that i open the pr versus that branch and fix the difference or that i open a new branch, add content and then open the pr?

Totally up to you @nfantoni , whatever is easier. Here's the link to update the base branch of a PR, or making a new one is also fine

I'll also actually throw out one more option, which is that you can wait until next week to make these changes. We are planning to merge the hip-0024-helm4-site-upgrade feature branch on early next week (hopefully Monday or Tuesday), which will update the site to use Docusaurus. At that point, since main will be updated to docusaurus, this PR could just be refactored and then merged to main.

hi @paigecalvert ,

i perform the pr #1836 into the branch. If it's ok we can close this. If you prefer that I start from main when it's merged, we can close the #1836 also and i repeat to main when it's done.

nfantoni avatar Oct 26 '25 18:10 nfantoni

hi @paigecalvert , I've open new PR #1857 starting from main branch after merge new version. We can close this and work on the other for a clear situation.

@karenhchu , @TerryHowe thanks for your approves in this pr

nfantoni avatar Oct 30 '25 10:10 nfantoni