nextsilicon-itay-bookstein

Allow customization of signal handler in registration, add flushing

1

Thank you for making this library, it's very useful to us! This PR tries to address a couple of minor pain points we encountered when using the library: * Makes...

cmake: Add deduplication of test cases when they have the same name

2

Because in doctest multiple test cases may share the same name regardless of suite scope (if any), and they therefore cannot always be addressed individually, improve CTest discovery behavior by...

Ftn_strcmp_klen return value type should be int like its similar sibling functions and like the compiler assumes when generating a call to this function. Signed-off-by: Itay Bookstein

Fix TOCTOU in create_dirs_impl

1

Replace the check whether a directory exists before trying to create it with handling for already-exists cases. This addresses a race where the directory is created by another process, leading...

Add dist sink support

1

Hi again! I implemented support for dist sinks (including verification that no circular references are made), and we're already using them. Was wondering whether you'd be interested. I saw that...

Use DEPFILE instead of implementing a custom parser?

2

It seems that `cython` has a `--depfile` argument and cmake's `add_custom_command` has a `DEPFILE` argument meant for this sort of thing. I'm not aware of the historical context, but perhaps...

Homogeneous container remapping code fails for some containers

2

Hi, @Naios ! Thanks for making `continuable`, it's a neat library! I passed an `absl::InlinedVector` to `cti::when_all()`, and to my surprise the continuables in it did not get connected to...

Forcing un-pure wheel, computing the wheel name in advance

1

The well-trod path for building python extension modules is by letting their build be driven by the setuptools machinery. I tried to drive the build of some extensions from another...

Exec-ing ninja when profitable?

4

As it currently stands, the `_program` function in `src/ninja/__init__.py` uses `subprocess.call`. When used via the `ninja` main, it merely waits for the exit-code and then propagates it as its own....

[Bug]: Sanitizer options may disagree between library and user leading to ODR violations

1

### Describe the issue I got an ODR violation stemming from compiling the library without sanitizers and linking against it from code that is compiled with sanitizers enabled. The definition...