spdlog_setup icon indicating copy to clipboard operation
spdlog_setup copied to clipboard

Add dist sink support

Open nextsilicon-itay-bookstein opened this issue 3 years ago • 1 comments

Hi again!

I implemented support for dist sinks (including verification that no circular references are made), and we're already using them. Was wondering whether you'd be interested. I saw that they were documented as 'not part of the use case', but I figured they might be useful for others some time or other, for grouping/aggregation within the configuration file :)

I'm a bit dissatisfied with the two dynamic casts, but alas, there is no common base class for both template instantiations that would allow me to call the relevant API, and I didn't want to propagate 'redundant' information through parameters.

Codecov Report

Merging #69 (cb3e807) into master (a991861) will increase coverage by 0.19%. The diff coverage is 92.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   88.16%   88.35%   +0.19%     
==========================================
  Files           4        4              
  Lines         566      601      +35     
==========================================
+ Hits          499      531      +32     
- Misses         67       70       +3     
Impacted Files Coverage Δ
include/spdlog_setup/details/conf_impl.h 90.26% <92.10%> (+0.10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a991861...cb3e807. Read the comment docs.

codecov[bot] avatar Dec 27 '20 10:12 codecov[bot]