Artyom Pavlov

Results 503 comments of Artyom Pavlov

I think this issue was closed prematurely. At the very least, it should've been closed in favor of a new issue dedicated to migration to `buffer-trait`. I tried to mirror...

The problem is that `buffer_trait::Buffer` does not implement `rustix::buffer::Buffer`, so I can't pass the former to functions which expect the latter. And I can not get raw pointer and length...

Sorry, my previous (deleted) comment was incorrect.

I think that changing behavior of `?` in `try` blocks is a really big drawback of this proposal. It introduces a very visible inconsistency to the language, which arguably will...

I don't think we need the `ref` folder for anything. It does not look like it's used for tests or something like this. Or am I missing something? >Compiler version...

The `mgm` CI failure is fixed in #654, so you need to rebase.

I don't have a particular preference, so I am fine with both options. I wonder if we should use an associated type, instead of simple byte slice. For example, cSHAKE...

The new SHA512 instructions should be leveraged using intrinsics in the `sha2` crate. Unfortunately, the relevant intrinsics and target features are currently unstable, so this new backend would have to...

`_mm256_sha512*` intrinsics [work](https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=sha512&ig_expand=5881) on YMM registers, so I guess it should be possible to polyfill them. Also, surprisingly, `std` does not have those intrinsics yet (or they were removed).