Artyom Pavlov

Results 503 comments of Artyom Pavlov

How about some crates from [RustCrypto](https://github.com/RustCrypto)? `sha2`, `sha3` and one of AES crates can be a good start.

BTW, I've [reworked](https://github.com/RustCrypto/hashes/pull/17) `blake2` crate based on this crate, so now they have the same performance.

@abonander I don't think it's a practical option. To my best knowledge, we can not generate "bindings" to the WASM target, since it's literally unknown (i.e. `wasm32-unknown-unknown`), so we don't...

I've also wrote a small CLI tool to check that pure Rust and `libflif` produce the same decoding result. (it accepts file paths via stdin ad does decoding and comparison...

I have several minor ideas how code can be improved, but not sure why you get a slowdown. It will be hard to tell without playing with the code. My...

Yes, I've wrote about it in my comment. IIUC currently you expose only transformation names and their order, without any internal information. If you think that it's worth to expose...

Yes, I agree about maniac. Regarding ugly matches you can use the following approach to make code a bit nicer: ```Rust // T1, T2, etc. transformations types defined in separate...

Added memory optimization to the list.

Another idea: we could drop generality over `Read` trait and instead assume that file is fully loaded into memory or memmap'ed. This will allow us to remove `Result` in several...

Maybe it's similar to https://github.com/rust-lang/rust/issues/88930? Can you check if changing `pub const K32: ...` to `pub static K32: ...` will improve codegen?