Artyom Pavlov

icon indicating an email [email protected]

Results 503 comments of Artyom Pavlov

dbl: retire crate and vendor implementation into downstream users?

It may be worth to also seal the `Dbl` trait. I agree that we should properly document the choice of polynomials. The `Dbl` methods are not used in hot path,...

Add unsafe test to check that dropped values are zeroized

Personally, while I am fine with having such test, I don't see much worth in it. I will leave the final decision to @tarcieri. As a small suggestion, it may...

Add unsafe test to check that dropped values are zeroized

@tarcieri WDYT? I lean towards closing this PR.

Add unsafe test to check that dropped values are zeroized

Closing in favor of #1199

fix: `missing_debug_implementations`

This PR got outdated, so I will close it in favor of tracking issue #599.

Exclude non-`include`d dotfiles regardless of the used VCS

>I would personally argue for the [principle of least surprise](https://en.wikipedia.org/wiki/Principle_of_least_astonishment) by not excluding things IMO making an exception for git goes against this principle. Excluding files in .gitignore (or any...

Exclude non-`include`d dotfiles regardless of the used VCS

>unless we made an exemption for .cargo Making an exception for `.cargo` sounds like a bad idea to me. For example, I plan to use .cargo/config.toml with `resolver.incompatible-rust-versions = "allow"`...

Add AES SIV examples

This looks fine to me and I think we can merge it after fixing the conflict.

Add AES SIV examples

Thank you!

Crate for choosing between 32-bit and 64-bit arithmetic backends

I think it would make sense to define it first inside `crypto-bigint` and only if the functionality will be needed by another crate, move it into `cpufeatures` or a different...