netzknecht

Results 8 comments of netzknecht

I realized that there are some redundant observers in `Lunar\Observers` namespace, if the trait is used but also, that there are some special cases on determining the presence of only...

@glennjacobs and @alecritson, before I spend more time into this, what do you think about using the [spatie/eloquent-sortable](https://github.com/spatie/eloquent-sortable) package for manual sorting instead. It should cover all requirements for lunar...

Hi @alecritson, this is not a fix, it's an enhancement or extension. Currently, lunar uses translations as json data in regular laravel database attributes/fields and in lunar attributes, too. The...

@glennjacobs due to the way in which the `handle` was automatically generated from `attributable_type` and `name` when storing `AttributeGroup` models in the hub, the problem of the incorrectly defined unique...

So far there is no practical need to fetch`AttributeGroup` models based on their `handle`. I think there is no reason why to place this change in the upgrade guide. However,...

@glennjacobs and @alecritson please check out and review the changes of my last commits regarding your previous concerns. Thank you!

Because this pull request is a fix and an enhancment, it could be better to merge it into main branch?

No, it should be full backward compatible. But I will add some general info to the documentation.