lunar icon indicating copy to clipboard operation
lunar copied to clipboard

Configurable default measurement units

Open netzknecht opened this issue 1 year ago • 5 comments

  • remove partly wrong default measurement units from database ('weight' and 'volume' unit isn't 'mm')
  • allow configuration of default measurement units in config file shipping.php with 'default' => true key/value pair
  • refactoring attribute getter methods to attribute casting accessor with correct default values

netzknecht avatar Nov 10 '23 14:11 netzknecht

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2023 6:15am

vercel[bot] avatar Nov 10 '23 14:11 vercel[bot]

Because this pull request is a fix and an enhancment, it could be better to merge it into main branch?

netzknecht avatar Nov 10 '23 14:11 netzknecht

Do you see any changes this would cause that would need explaining in the upgrade guide?

alecritson avatar Dec 01 '23 15:12 alecritson

No, it should be full backward compatible. But I will add some general info to the documentation.

netzknecht avatar Dec 01 '23 16:12 netzknecht

@netzknecht could you retarget to 0.8 branch please?

glennjacobs avatar Dec 18 '23 19:12 glennjacobs

This PR seems to have lots of updates not associated to the functionality specified. Closing, but feel free to reopen if you can make a PR that is focused on a single issue.

glennjacobs avatar May 06 '24 19:05 glennjacobs