John Adams comments

Results 19 comments of


                                            John Adams

app-battle.c getPrevShip( ) bug

Thanks for the bug report, we'll look into it!

DoubleMax Aggregation not supported

Same goes for floatMax, no support there either. I think this library is largely incomplete and doesn't support features in the latest druid (0.20)

DoubleMax Aggregation not supported

fwiw, I ended up abandoning this library and moving over to Imply Ply and using druidRequestor outside of Ply for JSON queries, which returns promises. It seems to be far...

Memory Leak with invalid status code

Rate limiting isn't the answer when there are actual memory leaks to contend with. I'm testing these patches on my install now.

[Question] Does it include X-Forward headers?

I realize this is like a two year old question, but the proxy will copy headers but as best I can tell will not set the two headers you describe.

Outline is incompatible with "Block All Public Access" on the S3 bucket.

I might have some time to explore this. It's not slower to load images at all. The signing is pretty fast and once cached by the browser even faster.

Outline is incompatible with "Block All Public Access" on the S3 bucket.

I believe that #3694 fixes this issue so I'm going to close it. reopen if needed.

Outline is incompatible with "Block All Public Access" on the S3 bucket.

Wait, no, on #3694 they say it's not a bug. It most certainly is a problem for people using authenticated s3 endpoints.

Outline is incompatible with "Block All Public Access" on the S3 bucket.

> Why just not save all public images in database? Because storing large binary blobs in a relational database is an improper use of a database. Another disadvantage is that...

Outline is incompatible with "Block All Public Access" on the S3 bucket.

that doesn't work when BPA is enabled -- the policy is ignored afaik