neomonkeus

Results 136 comments of neomonkeus

Adding @niftools/3ds-max-reviewers for review. Code content wise, it is pretty unwieldy to review the whole thing. Not sure what is the best way to review this. Github only allows a...

I suppose general coding conventions. If you mean ignore whitespaces on commit, then yes if possible as it makes it harder to review if nothing else.

I personally don't mind what convention is used. However, I would suggest using the older one, to perform a functional review first. Then if the code style is preferable (and...

See - https://github.com/blog/967-github-secrets Also, github vs gitlab :D

@blabbatheorange I agree. If I get time I will create a duplicate develop branch, and this can be merged and I can rename that branch to the proposed name. Still...

We found that there was several other issues between the previous release version and this version The flip for between .material.material might get you forward one step but breaks other...

@fractalfederation The version of pyffi you ran against doesn't currently support the version of the nif format that you are trying to optimize. In order to bump up to the...

Is this a generic problem or specific to only that use case. I wouldn't like to update it and then break everything else in the process that might rely on...

Check out my branch here - https://github.com/niftools/pyffi/compare/develop...neomonkeus:hfloat It has some required additions that I would want to have included along with this. Regarding usage of latest nif.xml. It breaks in...

@fractalfederation Although this would update add the base support to read the block into memory, the way the BSTriShape stores the vertex data probably would require the spell to be...