NeoForge

NeoForge copied to clipboard

FluidResource and ItemResource proof of concept

6

Currently throwing ideas around... `FluidStack` and `ItemStack` are very convenient, but they are also mutable. There are cases where we want to prevent mutation of fluid and item stacks. There...

Technici4n

Guard recipe serializers against supplying null codecs

1

Returning null from `RecipeSerializer#codec()` produces a nonsensical gibberish error - we should validate them at registration time or shortly thereafter. ``` java.lang.NullPointerException: Cannot invoke "com.mojang.serialization.Decoder.decode(com.mojang.serialization.DynamicOps, Object)" because "c" is null...

Shadows-of-Fire

Allow modders to opt in to have their config be loaded early

2

Long story short, there's use cases beyond the frowned-upon conditional registration that modders need to have early configs for. Myself, I had use cases where I was using EntityAttributeModificationEvent to...

TelepathicGrunt

Unnecessary `useCombinedDepthStencilAttachment` client config value

3

The config value can be found [here](https://github.com/neoforged/NeoForge/blob/1.20.x/src/main/java/net/neoforged/neoforge/common/NeoForgeConfig.java#L87). The only place it used in NeoForge is [here](https://github.com/neoforged/NeoForge/blob/1.20.x/patches/com/mojang/blaze3d/pipeline/RenderTarget.java.patch#L20). To me to is strange that the user should be able to configure this....

PepperCode1

[IBlockStateExtension#getBeaconColorMultiplier](https://github.com/neoforged/NeoForge/blob/1.20.x/src/main/java/net/neoforged/neoforge/common/extensions/IBlockStateExtension.java#L427-L428) and [IBlockExtension#getBeaconColorMultiplier](https://github.com/neoforged/NeoForge/blob/1.20.x/src/main/java/net/neoforged/neoforge/common/extensions/IBlockExtension.java#L533-L534) should both be `float @Nullable []`. The current annotation position says that they return a "non null array of nullable `float`s" instead of the wanted "nullable array...

PlatinPython

The vanilla method `Mob#setTarget` has the following signature: `public void setTarget(@Nullable LivingEntity p_21544_)`, and the `LivingChangeTargetEvent` is fired from within this method. However, neither `CommonHooks.onLivingChangeTarget` nor the event itself have...

Shadows-of-Fire

The "Cancel" button when the player loads a world with experimental settings behaves strangely.

1

**NeoForge Version:** 20.4.118-beta **Logs:** https://gist.github.com/Lolothepro/94f6df87b94d295bda37b589f136f3c0 **Steps to Reproduce:** 1. Load a world for the first time with experimental settings 2. Press Cancel 3. The world doesn't load 4. Go to...

Lolothepro

CropGrowEvent usually have a blockstate for growing block, however, it's impossible to get growing block from GrowingPlantHeadBlock as it calls event by: ``` net.neoforged.neoforge.common.CommonHooks.onCropsGrowPre(pLevel, pPos.relative(this.growthDirection), pLevel.getBlockState(pPos.relative(this.growthDirection)), pRandom.nextDouble() < this.growPerTickProbability) ```...

khjxiaogu

Just musing about a few things that would make horse armor more extensible. 1. Delegate `Horse#setArmorEquipment` to `HorseArmorItem` so that armor can apply more attribute modifiers than just the armor...

Shadows-of-Fire

[1.20.1] Pull `ProjectileHitEvent` changes from MCF/1.20.x

4

This PR is a subset of #14 which pulls only the changes from https://github.com/MinecraftForge/MinecraftForge/pull/9642

Shadows-of-Fire