NeoForge

NeoForge copied to clipboard

Cancelling BlockEvent.EntityPlaceEvent causes itemstack desync

1

MC 1.20.4, NF 20.4.0-beta if i cancel BlockEvent.EntityPlaceEvent (server-only event for placing blocks), blockitem count is shrunk on client (block disappears from hotbar if there was only one piece). opening...

moonfather1

Verify some IExtensibleEnum during the connection phase

3

Adds a Payload that is sent during configuration phase of a connection to verify certain extensible enums from being the same. This prevents hard to track down issues by making...

agnor99

Replace PlantType system with SpecialPlantable interface and canSustainPlant block method

3

It is well known the old PlantType system used in past is quite clunky and broken in many areas. It does not even cover some important vanilla plants such as...

TelepathicGrunt

Add hook for projectile weapon to define default ammo

1

The issue is that a Creative Mode player without valid ammo for a modded projectile weapon will be given vanilla Arrow in LivingGetProjectileEvent. To get around this, a getDefaultCreativeAmmo method...

TelepathicGrunt

ChunkEvent.Unload is called before ChunkDataEvent.Save

2

**Minecraft Version:** 1.20.1 **Forge Version:** 47.1.76 **Steps to Reproduce:** https://github.com/neoforged/NeoForge/blob/0974ecc143f449087139a6923aa3f0823dce421d/patches/minecraft/net/minecraft/server/level/ChunkMap.java.patch#L15 I suggest the patch needs to be updated to move the `ChunkEvent.Unload` to be _after_ `save()` probably near the `level.unload()`...

Adam8234

Following the GUI rendering changes in 1.20.5, `HeartType` no longer references hardcoded U/V coordinates and instead references individual sprites. This means that it is possible to add new HeartType(s) by...

Shadows-of-Fire

Java's `parallelStream()` method accesses the `ForkJoinPool.commonPool` when distributing the work, but this thread pool has the incorrect classloader when being used in an environment with Modules. This makes `parallelStream()` effectively...

Shadows-of-Fire

PlayMessages.OpenContainer swallows exceptions during screen construction

3

Any exceptions thrown during the construction of a screen will be ignored entirely, and the screen will fail to open. This is due to the following `try/finally` block not having...

Shadows-of-Fire