Jackie Pi3tal comments

Results 106 comments of


                                            Jackie Pi3tal

add query string parameters for setting panel width

cc @makerslabemlyon

Easily add libraries from CDN

you got `+ add library` button in top left? why cdn if the only difference is they are fetched from `unpkg` example: https://unpkg.com/bootstrap

ES-Import boilerplate is not working: SyntaxError

works with me

Offset not exposed on Circle, though present on SAT implementation

I managed to implement offset for circles @BobGneu please check v6.6.0

Offset not exposed on Circle, though present on SAT implementation

> Looks like the signature for setOffset is not exactly correct, SAT appears to expose setOffset such that it should return a Circle. > > Something like this may be...

Offset not exposed on Circle, though present on SAT implementation

please try v6.6.1 where I did as you mentioned above

Offset not exposed on Circle, though present on SAT implementation

closing until something else wrong with offset on circle :) feel free to reopen if something wrong

Concave polygons not working as expected

you're right @kade-robertson and what @Codezilluh wrote is also true I will add some remark to readme about this and then close the issue as I personally don't plan to...

Concave polygons not working as expected

I added the information to readme -> https://github.com/Prozi/detect-collisions#concave-polygons closing the issue as aInB and bInA for non-convex will stay this way until some good merge request appears with how to...

feature-request: Extend Benchmarking

I updated the benchmark to be more deterministic and used it inside the circle ci build process https://app.circleci.com/pipelines/github/Prozi/detect-collisions example: https://app.circleci.com/pipelines/github/Prozi/detect-collisions/156/workflows/61b5a6fd-9947-4443-9517-f4a28251cd05/jobs/130 ![image](https://user-images.githubusercontent.com/3052357/200892132-d3393a0f-74af-4496-93ae-ee0998dfb794.png)