Jackie Pi3tal
Jackie Pi3tal
> Good day, > > I have recently been working with the Circle bodies and have a case where the offset value would be very helpful. > > https://github.com/jriecken/sat-js/blob/master/SAT.js#L291-L294 >...
> Quick update > > So, looks like the calculations for the aabb of the circle are not taking the offset value into account. I am still debugging, More details...
I've created a branch for test purpouses of this issue https://github.com/Prozi/detect-collisions/tree/issue-36 please check it out @BobGneu it seems if you run ``` yarn build yarn demo ``` and open the...
hello thanks for suggestions i will try to connect https://github.com/Prozi/detect-collisions#benchmark with some changes with what you linked
I will look into it thank you for reporting!
glad to report that I fixed it in v6.3.6 it was an overlook I also updated the CI tests to add this case and even added the polygon to the...
> glad to report that I fixed it in v6.3.6 it was an overlook > > I also updated the CI tests to add this case and even added the...
> Cool, now it appears the polygons are being generated properly. Yes I fixed the convexPolygons array length to be === this.getConvex().length also fixed collision resolution between circles and concaves...
@Codezilluh please try v6.3.8 I added those vectors since it was relatively simple, all tests still pass and in the demo I dont have such behaviour [no more]
> Alright, I fixed it > > You need to do `this.response.clear();` in the `reduce`s > > Should I create a pull request? Nice find! I thought about also skipping...