Marcin Jałocha comments

Results 58 comments of


                                            Marcin Jałocha

creature:removeCondition doesn't work properly with userdata

But thats your lua code logic problem, you have to use "creature:getCondition()" to pass it to removeCondition to remove proper condtion. Ofc it won't remove proper condition if you are...

creature:removeCondition doesn't work properly with userdata

IMO this is complicating the code for no reason, so I'm against this change, you can wait for what the others devs think though. It's also illogical to me to...

fix: depotchest memory leak

https://github.com/otland/forgottenserver/pull/3423 https://github.com/otland/forgottenserver/pull/3452

bring back the "old" quest system

https://pastebin.com/gGFgZSsF Not tested. Simply register in xml with action id 2000.

using addEvent with item that has no uniqueId

Use issue template.

using addEvent with item that has no uniqueId

Yeah I wrote something similar to you some time ago. Your code will fail to obtain stackables that were modified (merged, split, even moved, stacks are entirely remade), guid will...

Working on offline player from lua

This is already possible within IOLoginData in sources (example in mailbox.cpp), shouldn't be hard to do. I also recently wondered that it would be awesome to have in lua. Sometimes...

Add option to load offline player in lua

This code is creating memory leak each time you call loadPlayer (memory is allocated, but never freed) Probably the way I would implement this is by creating new metatable called...

fix: invalid numerics notation in session data

The issue seems to be deeper, in fosite to be exact. Nonetheless this type of number notation is valid.

[10.98] Creatures on screen appears to be dashing/teleporting to next tile when walking

Hey, nice that you found a fix, is that related to https://github.com/otland/otclient/pull/45? If not, can you please submit pull request with your fixes so we can review them?