forgottenserver icon indicating copy to clipboard operation
forgottenserver copied to clipboard

fix: depotchest memory leak

Open lyuz1n opened this issue 2 years ago • 2 comments

Pull Request Prelude

Changes Proposed

items on depot cannot destroy after player logout. after some relogins with around 100k items on depot...

BEFORE FIX: Captura de tela 2023-07-23 164438

AFTER FIX: Captura de tela 2023-07-23 164420

lyuz1n avatar Jul 23 '23 19:07 lyuz1n

https://github.com/otland/forgottenserver/pull/3423 https://github.com/otland/forgottenserver/pull/3452

nekiro avatar Jul 23 '23 21:07 nekiro

@nekiro is right, if you're going to change to a shared ptr, you must change it everywhere or you will get nasty double frees

ranisalt avatar Aug 15 '23 14:08 ranisalt