forgottenserver
forgottenserver copied to clipboard
fix: depotchest memory leak
Pull Request Prelude
- [x] I have followed proper The Forgotten Server code styling.
- [x] I have read and understood the contribution guidelines before making this PR.
- [x] I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.
Changes Proposed
items on depot cannot destroy after player logout. after some relogins with around 100k items on depot...
BEFORE FIX:
AFTER FIX:
https://github.com/otland/forgottenserver/pull/3423 https://github.com/otland/forgottenserver/pull/3452
@nekiro is right, if you're going to change to a shared ptr, you must change it everywhere or you will get nasty double frees