Damien Neil

Results 262 comments of Damien Neil

If we want opaque(-ish) constants, we could define: ``` type Kind byte const ( kindNull = Kind(' ') // ... ) const ( KindNull = kindNull // ... ) ```...

> what's included is based on WHATWG mime sniffing https://mimesniff.spec.whatwg.org/ this gives us a clear spec to adhere to, rather than an arbitrary list. net/http.DetectContentType is based on WHATWG's spec;...

Interestingly, the one case where we override the platform value (on Windows, we ignore a registry entry mapping `.js` to `text/plain`) is one where Chrome and Firefox apparently prefer the...

To recap the proposal: The `mime` package contains a built-in table mapping file extensions to MIME types. For example: ".png" maps to "image/png". This table is only used when the...

> Do the Chrome or Firefox tables ever change in a way that isn't purely additive? I don't know the answer to this. I propose that for the moment we...

We have `proto.Equal`, having `Compare` as well seems like a straightforward extension and a reasonable feature request. (I might, of course, be missing something that makes it less straightforward than...

Yes, I think we'd need a `protoreflect.Value.Compare` as well. (Note that I'm just an emeritus maintainer making a drive-by comment, current maintainers will be the ones to decide whether we...

The original `ResponseController` proposal (#54136) did explicitly mention `TimeoutHandler`, so we didn't forget about it at the time: > The Handler returned by http.TimeoutHandler currently receives a ResponseWriter which does...

To recap: - TimeoutHandler's timeout is fixed. You can't change it. - Within a TimeoutHandler, you can change the read/write deadline. This just affects reading from the request body and...

`jsontext.Decoder.PeekKind` returns `Kind(0)` on both error and EOF. This makes it impossible to distinguish between an error and the natural end of input without reading the next token. Maybe that's...