Damien Neil
Damien Neil
> At first glance this appears to be a breaking change This would break the following: ``` var _ = errors.As ```
I can consistently reproduce this as c26be72d, but not at HEAD, so I believe https://go.dev/cl/586249 already fixed this.
https://protobuf.dev/reference/go/go-generated/#invocation documents Go code generator flags. (I don't think the `annotate_code` option is documented, but it's also incredibly specialized and you almost certainly don't care about it unless you're trying...
`annotate_code` emits a `.meta` file alongside each `.pb.go` containing a `GeneratedCodeInfo`. (See `descriptor.proto` for the definition.) Where `SourceCodeInfo` is created by `protoc` and describes the relationship between a `.proto` source...
Works for me. Can you provide the complete `.proto` file and complete Go code? ``` func Test(t *testing.T) { m := &testoptspb.TestMessageWithCustomOptions{} md := m.ProtoReflect().Descriptor() fd := md.Fields().ByName("map_field") v :=...
The proposal reuses the types from the x/net/http2 Server and Transport. HTTP/2 settings are defined as 32-bit unsigned integers; I don't know for sure, but I'd guess that's the reason...
A minor change to rename two fields: `MaxUploadBufferPerConnection` is now `MaxReceiveBufferPerConnection`. `MaxUploadBufferPerStream` is now `MaxReceiveBufferPerStream`. These fields originate as `http2.Server` fields, where "upload" unambiguously refers to the flow control window...
Yes, we have everything in 1.24 except for `Transport.StrictMaxConcurrentRequests`. Some questions about `StrictMaxConcurrentRequests` came up in review, and I was still thinking through whether we want to promote it to...
Is there a reason for having separate `SVCBResource` and `HTTPSResource` types? The HTTPS RR type is "SVCB-compatible" and has an identical representation. It seems like it would be sufficient to...
General API looks fine to me, but I suggest a couple small changes: 1. Remove the `HTTPSResource` type, and use `SVCBResource` as the type used by `Parser.HTTPSResource` and `Builder.HTTPSResource`. The...