Damien Neil
Damien Neil
HTTPS RRs have a different RR type than SVCB RRs, but they are "SVCB-compatible" (see [RFC 9460 section 6](https://www.rfc-editor.org/rfc/rfc9460.html#section-6)) and use the same RDATA presentation format, wire format, SvcParamKeys registry,...
> Treating Params as []Param may be sensible for performance reasons, but note that the format is designed to support representations like map[ParamKey][]byte (e.g. duplicate keys are forbidden) and this...
Does this look right? A few points that have changed from https://go.dev/cl/284852: - I dropped the HTTPSResource method from Parser and Builder. Just use SVCBResource for the HTTPS RR type....
Okay, adding the HTTPSResource methods back in: ```go // HTTPSResource parses a single HTTPS resource as a SVCBResource. // // One of the XXXHeader methods must have been called before...
If `Params` is a slice, then perhaps sort it when packing, but only if it is not sorted already? I agree, duplicate entries should be an error.
New code should use `google.golang.org/protobuf`. `github.com/golang/protobuf` is deprecated. Versions v1.4.0 and newer of that module are mostly a wrapper around the newer `google.golang.org/protobuf` module. Existing programs that use `github.com/golang/protobuf` may...
A protobuf message is any type that implements `"google.golang.org/protobuf/proto".Message`. The `*embedMessage` type implements `proto.Message`, therefore it's a message. However, a nil `*embedMessage` panics when its `ProtoReflect` method is called, therefore...
A repeated field, map value, or oneof field containing a nil message is equal to one containing a non-nil, empty one, so the behavior for cases 1, 2, and 3...
If we were to add anything, I think it would be: ```go package context // Error is an error value which matches Canceled and DeadlineExceeded. // // To test to...
I'm not sure that we'd want to do anything here. The `go-cmp/cmp` package is intended for use in tests, and the package documentation is clear on this: > It is...