Damien Neil

> Is this a duplicate of https://github.com/golang/go/issues/56036? Yes, due to the test being renamed from `TestServerShutdown_h2` to `TestServerShutdown/h2` in the Great Test Refactoring.

No-update update: Looked at this for a bit. Could not replicate on darwin-amd64-race builder. Could not find a plausible explanation for the flake. Admitting defeat for the moment.

The client returns the idle connection to the pool before returning from RoundTrip, exactly to ensure that a followup request picks it up: https://go.googlesource.com/go/+/refs/tags/go1.20/src/net/http/transport.go#2159 Maybe something is happening that causes...

Aha! Nice catch. Perhaps we should just disable the `maxWriteWaitBeforeConnReuse` timeout in tests.

Looks like the HTTP/2 server is reading from a buffer passed to `ResponseWriter.Write` after the `Write` call has returned, which is not okay.

> I'm hitting this repeatedly on TryBots even if I'm rebased on latest master. Sorry about that. Rolling back https://go.dev/cl/466865 until I figure out what new race condition is being...

This doesn't seem likely to be caused by https://go.dev/cl/438137, which refactored the way the test is invoked and its name but not the content of the test. The test sends...

Dropping the timeout might be reasonable. Although I'm a bit confused why it would be necessary, since `runtime.GC` should block until the GC is complete, by which point finalizers should...

A few more cases where closures are commonly used. * [strings.TrimFunc](http://godoc.org/strings#TrimFunc) * [http.HandlerFunc](http://godoc.org/net/http#HandlerFunc) * [Spanner row iteration](https://godoc.org/cloud.google.com/go/spanner#RowIterator) (I'm mainly trying to collect use cases at the moment to provide evidence...

Yes, it's the type declarations that really add noise. Unfortunately, "func (p) error" already has a meaning. Perhaps permitting _ to substitute in for an inferenced type would work? ```go...