net/http: data race involving `net/http.(*http2Framer).WriteDataPadded`
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
https://build.golang.org/log/8f9829a1eacef63f57dd92e8a7647ac7fdd04a3a:
==================
WARNING: DATA RACE
Write at 0x00c00085e000 by goroutine 5319:
net/http_test.neverEnding.Read()
/workdir/go/src/net/http/serve_test.go:3014 +0x78
net/http_test.(*neverEnding).Read()
<autogenerated>:1 +0x1f
io.copyBuffer()
/workdir/go/src/io/io.go:428 +0x2c8
io.Copy()
/workdir/go/src/io/io.go:386 +0x57
net/http_test.testIssue4191_InfiniteGetTimeout.func1()
/workdir/go/src/net/http/transport_test.go:2229 +0x13
net/http.HandlerFunc.ServeHTTP()
/workdir/go/src/net/http/server.go:2111 +0x47
net/http.(*ServeMux).ServeHTTP()
/workdir/go/src/net/http/server.go:2489 +0xbc
net/http.serverHandler.ServeHTTP()
/workdir/go/src/net/http/server.go:2925 +0x682
net/http.initALPNRequest.ServeHTTP()
/workdir/go/src/net/http/server.go:3538 +0x34d
net/http.(*initALPNRequest).ServeHTTP()
<autogenerated>:1 +0x7b
net/http.Handler.ServeHTTP-fm()
<autogenerated>:1 +0x67
net/http.(*http2serverConn).runHandler()
/workdir/go/src/net/http/h2_bundle.go:6049 +0xe1
net/http.(*http2serverConn).processHeaders.func1()
/workdir/go/src/net/http/h2_bundle.go:5762 +0x5d
Previous read at 0x00c00085e000 by goroutine 5251:
runtime.slicecopy()
/workdir/go/src/runtime/slice.go:310 +0x0
net/http.(*http2Framer).WriteDataPadded()
/workdir/go/src/net/http/h2_bundle.go:2025 +0x4dc
net/http.(*http2Framer).WriteData()
/workdir/go/src/net/http/h2_bundle.go:1985 +0xdc
net/http.(*http2writeData).writeFrame()
/workdir/go/src/net/http/h2_bundle.go:10220 +0x1a
net/http.(*http2serverConn).writeFrameAsync()
/workdir/go/src/net/http/h2_bundle.go:4589 +0x85
net/http.(*http2serverConn).startFrameWrite.func1()
/workdir/go/src/net/http/h2_bundle.go:5000 +0x6b
Goroutine 5319 (running) created at:
net/http.(*http2serverConn).processHeaders()
/workdir/go/src/net/http/h2_bundle.go:5762 +0xdfb
net/http.(*http2serverConn).processFrame()
/workdir/go/src/net/http/h2_bundle.go:5262 +0x445
net/http.(*http2serverConn).processFrameFromReader()
/workdir/go/src/net/http/h2_bundle.go:5205 +0x2de
net/http.(*http2serverConn).serve()
/workdir/go/src/net/http/h2_bundle.go:4694 +0x15b0
net/http.(*http2Server).ServeConn()
/workdir/go/src/net/http/h2_bundle.go:4270 +0x181d
net/http.http2ConfigureServer.func1()
/workdir/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3078 +0x4f
Goroutine 5251 (finished) created at:
net/http.(*http2serverConn).startFrameWrite()
/workdir/go/src/net/http/h2_bundle.go:5000 +0x5fa
net/http.(*http2serverConn).scheduleFrameWrite()
/workdir/go/src/net/http/h2_bundle.go:5102 +0x3c8
net/http.(*http2serverConn).wroteFrame()
/workdir/go/src/net/http/h2_bundle.go:5062 +0x469
net/http.(*http2serverConn).serve()
/workdir/go/src/net/http/h2_bundle.go:4690 +0x154b
net/http.(*http2Server).ServeConn()
/workdir/go/src/net/http/h2_bundle.go:4270 +0x181d
net/http.http2ConfigureServer.func1()
/workdir/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3078 +0x4f
==================
https://build.golang.org/log/abcd1afb8c807a6e0947447747212fe2afa0183b:
==================
WARNING: DATA RACE
Write at 0x00c000b68000 by goroutine 23273:
net/http_test.neverEnding.Read()
/workdir/go/src/net/http/serve_test.go:3014 +0x78
net/http_test.(*neverEnding).Read()
<autogenerated>:1 +0x1f
io.copyBuffer()
/workdir/go/src/io/io.go:428 +0x2c8
io.Copy()
/workdir/go/src/io/io.go:386 +0x2ee
net/http.(*response).ReadFrom()
/workdir/go/src/net/http/server.go:601 +0x27f
io.copyBuffer()
/workdir/go/src/io/io.go:420 +0x1ef
io.Copy()
/workdir/go/src/io/io.go:386 +0x57
net/http_test.testIssue4191_InfiniteGetToPutTimeout.func1()
/workdir/go/src/net/http/transport_test.go:2268 +0x13
net/http.HandlerFunc.ServeHTTP()
/workdir/go/src/net/http/server.go:2111 +0x47
net/http.(*ServeMux).ServeHTTP()
/workdir/go/src/net/http/server.go:2489 +0xbc
net/http.serverHandler.ServeHTTP()
/workdir/go/src/net/http/server.go:2925 +0x682
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1984 +0xbe4
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3078 +0x4f
Previous read at 0x00c000b68000 by goroutine 23266:
runtime.slicecopy()
/workdir/go/src/runtime/slice.go:310 +0x0
net/http.(*http2Framer).WriteDataPadded()
/workdir/go/src/net/http/h2_bundle.go:2025 +0x4dc
net/http.(*http2Framer).WriteData()
/workdir/go/src/net/http/h2_bundle.go:1985 +0xdc
net/http.(*http2writeData).writeFrame()
/workdir/go/src/net/http/h2_bundle.go:10220 +0x1a
net/http.(*http2serverConn).writeFrameAsync()
/workdir/go/src/net/http/h2_bundle.go:4589 +0x85
net/http.(*http2serverConn).startFrameWrite.func1()
/workdir/go/src/net/http/h2_bundle.go:5000 +0x6b
Goroutine 23273 (running) created at:
net/http.(*Server).Serve()
/workdir/go/src/net/http/server.go:3078 +0x817
net/http/httptest.(*Server).goServe.func1()
/workdir/go/src/net/http/httptest/server.go:310 +0xaa
Goroutine 23266 (finished) created at:
net/http.(*http2serverConn).startFrameWrite()
/workdir/go/src/net/http/h2_bundle.go:5000 +0x5fa
net/http.(*http2serverConn).scheduleFrameWrite()
/workdir/go/src/net/http/h2_bundle.go:5102 +0x3c8
net/http.(*http2serverConn).wroteFrame()
/workdir/go/src/net/http/h2_bundle.go:5062 +0x469
net/http.(*http2serverConn).serve()
/workdir/go/src/net/http/h2_bundle.go:4690 +0x154b
net/http.(*http2Server).ServeConn()
/workdir/go/src/net/http/h2_bundle.go:4270 +0x181d
net/http.http2ConfigureServer.func1()
/workdir/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3078 +0x4f
==================
This may have been introduced in or around CL 456555.
Looks like the HTTP/2 server is reading from a buffer passed to ResponseWriter.Write after the Write call has returned, which is not okay.
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && `DATA RACE` && `net/http\.\(\*http2Framer\)\.WriteDataPadded` && `net/http_test\.neverEnding\.Read`
2023-01-31 19:43 linux-amd64-longtest-race go@b89a840d net/http.TestIssue4191_InfiniteGetToPutTimeout (log)
==================
WARNING: DATA RACE
Write at 0x00c000b68000 by goroutine 23273:
net/http_test.neverEnding.Read()
/workdir/go/src/net/http/serve_test.go:3014 +0x78
net/http_test.(*neverEnding).Read()
<autogenerated>:1 +0x1f
io.copyBuffer()
/workdir/go/src/io/io.go:428 +0x2c8
io.Copy()
...
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestIssue4191_InfiniteGetToPutTimeout (0.51s)
--- FAIL: TestIssue4191_InfiniteGetToPutTimeout/h1 (0.51s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
2023/01/31 20:16:22 Unsolicited response received on idle HTTP channel starting with "HTTP/1.1 204 No Content\r\nConnection: close\r\n\r\n"; err=<nil>
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-01 19:47 linux-amd64-race go@ab0f0459 net/http.TestHeadResponses (log)
--- FAIL: TestHeadResponses (0.00s)
--- FAIL: TestHeadResponses/h1 (0.03s)
testing.go:1446: race detected during execution of test
--- FAIL: TestHeadResponses/h2 (0.04s)
testing.go:1446: race detected during execution of test
2023-02-01 19:47 linux-amd64-race go@ab0f0459 net/http.TestNoContentLengthIfTransferEncoding (log)
--- FAIL: TestNoContentLengthIfTransferEncoding (0.00s)
2023-02-01 19:47 linux-amd64-race go@ab0f0459 net/http.TestIssue3644 (log)
--- FAIL: TestIssue3644 (0.00s)
--- FAIL: TestIssue3644/h2 (0.04s)
testing.go:1446: race detected during execution of test
--- FAIL: TestIssue3644/h1 (0.04s)
testing.go:1446: race detected during execution of test
2023-02-01 21:30 darwin-amd64-race go@4b7f7eef net/http.TestTransportReadToEndReusesConn (log)
--- FAIL: TestTransportReadToEndReusesConn (0.03s)
--- FAIL: TestTransportReadToEndReusesConn/h1 (0.07s)
testing.go:1446: race detected during execution of test
--- FAIL: TestTransportReadToEndReusesConn/h2 (0.06s)
testing.go:1446: race detected during execution of test
2023-02-01 21:30 darwin-amd64-race go@4b7f7eef net/http.TestServerNoDate (log)
--- FAIL: TestServerNoDate (0.01s)
2023-02-01 21:30 darwin-amd64-race go@4b7f7eef net/http.TestTransportIDNA (log)
--- FAIL: TestTransportIDNA (0.00s)
2023-02-01 21:30 darwin-amd64-race go@4b7f7eef net/http.TestServerKeepAlivesEnabledResultClose (log)
--- FAIL: TestServerKeepAlivesEnabledResultClose (0.00s)
Change https://go.dev/cl/465157 mentions this issue: net/http: fix race in http2chunkWriter.Write
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-04 07:03 darwin-amd64-race go@25f5d9d4 net/http.TestTransportGzipRecursive (log)
==================
WARNING: DATA RACE
Write at 0x00c0007e8000 by goroutine 17430:
runtime.racewriterange()
<autogenerated>:1 +0x24
internal/poll.ignoringEINTRIO()
/tmp/buildlet/go/src/internal/poll/fd_unix.go:793 +0x419
internal/poll.(*FD).Read()
/tmp/buildlet/go/src/internal/poll/fd_unix.go:163 +0x22
net.(*netFD).Read()
...
net/http.(*http2Server).ServeConn()
/tmp/buildlet/go/src/net/http/h2_bundle.go:4270 +0x183d
net/http.http2ConfigureServer.func1()
/tmp/buildlet/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
/tmp/buildlet/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/tmp/buildlet/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestTransportGzipRecursive (0.00s)
2023-02-04 07:03 darwin-amd64-race go@25f5d9d4 net/http.TestOnlyWriteTimeout (log)
--- FAIL: TestOnlyWriteTimeout (0.00s)
--- FAIL: TestOnlyWriteTimeout/h1 (0.02s)
testing.go:1446: race detected during execution of test
2023-02-04 07:03 darwin-amd64-race go@25f5d9d4 net/http.TestFileServerSortsNames (log)
--- FAIL: TestFileServerSortsNames (0.00s)
--- FAIL: TestFileServerSortsNames/h2 (0.04s)
testing.go:1446: race detected during execution of test
--- FAIL: TestFileServerSortsNames/h1 (0.04s)
testing.go:1446: race detected during execution of test
2023-02-04 07:03 darwin-amd64-race go@25f5d9d4 net/http.TestShouldRedirectConcurrency (log)
--- FAIL: TestShouldRedirectConcurrency (0.00s)
2023-02-04 07:03 darwin-amd64-race go@25f5d9d4 net/http.TestServerIssue5953 (log)
--- FAIL: TestServerIssue5953 (0.04s)
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-04 07:03 linux-amd64-longtest-race go@25f5d9d4 net/http.TestIssue4191_InfiniteGetToPutTimeout (log)
==================
WARNING: DATA RACE
Write at 0x00c000d62000 by goroutine 23287:
net/http_test.neverEnding.Read()
/workdir/go/src/net/http/serve_test.go:3010 +0x6f
net/http_test.(*neverEnding).Read()
<autogenerated>:1 +0x1f
io.copyBuffer()
/workdir/go/src/io/io.go:428 +0x2c8
io.Copy()
...
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestIssue4191_InfiniteGetToPutTimeout (0.51s)
--- FAIL: TestIssue4191_InfiniteGetToPutTimeout/h1 (0.51s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
2023/02/04 07:35:43 Unsolicited response received on idle HTTP channel starting with "HTTP/1.1 204 No Content\r\nConnection: close\r\n\r\n"; err=<nil>
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-06 04:29 freebsd-amd64-race go@def0be5e net/http.TestServeFileContentType (log)
==================
WARNING: DATA RACE
Write at 0x00c001cc4000 by goroutine 18521:
runtime.racewriterange()
<autogenerated>:1 +0x24
internal/poll.ignoringEINTRIO()
/tmp/workdir/go/src/internal/poll/fd_unix.go:793 +0x419
internal/poll.(*FD).Read()
/tmp/workdir/go/src/internal/poll/fd_unix.go:163 +0x22
os.(*File).read()
...
net/http.http2ConfigureServer.func1()
/tmp/workdir/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
/tmp/workdir/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/tmp/workdir/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestServeFileContentType (0.00s)
--- FAIL: TestServeFileContentType/h2 (0.11s)
testing.go:1446: race detected during execution of test
2023-02-06 04:29 freebsd-amd64-race go@def0be5e net/http.TestFileServerMethodOptions (log)
--- FAIL: TestFileServerMethodOptions (0.00s)
--- FAIL: TestFileServerMethodOptions/h1 (0.05s)
testing.go:1446: race detected during execution of test
--- FAIL: TestFileServerMethodOptions/h2 (0.05s)
testing.go:1446: race detected during execution of test
2023-02-06 04:29 freebsd-amd64-race go@def0be5e net/http.TestFileServerSortsNames (log)
--- FAIL: TestFileServerSortsNames (0.00s)
--- FAIL: TestFileServerSortsNames/h2 (0.04s)
testing.go:1446: race detected during execution of test
2023-02-06 04:29 freebsd-amd64-race go@def0be5e net/http.TestFileServerImplicitLeadingSlash (log)
--- FAIL: TestFileServerImplicitLeadingSlash (0.00s)
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-06 12:49 darwin-amd64-race go@a432d891 net/http.TestTimeoutHandlerRace (log)
--- FAIL: TestTimeoutHandlerRace (0.01s)
--- FAIL: TestTimeoutHandlerRace/h2 (0.17s)
testing.go:1446: race detected during execution of test
--- FAIL: TestTimeoutHandlerRace/h1 (0.17s)
testing.go:1446: race detected during execution of test
2023-02-06 12:49 darwin-amd64-race go@a432d891 net/http.TestTransportIssue10457 (log)
--- FAIL: TestTransportIssue10457 (0.01s)
2023-02-06 12:49 darwin-amd64-race go@a432d891 net/http.TestDontCacheBrokenHTTP2Conn (log)
--- FAIL: TestDontCacheBrokenHTTP2Conn (0.01s)
--- FAIL: TestDontCacheBrokenHTTP2Conn/h2 (0.30s)
transport_test.go:6327: got conn: 127.0.0.1:53996, reused=false, wasIdle=false, idleTime=0s
testing.go:1446: race detected during execution of test
2023-02-06 12:49 darwin-amd64-race go@a432d891 net/http.TestRequestLimit (log)
--- FAIL: TestRequestLimit (0.00s)
--- FAIL: TestRequestLimit/h2 (2.99s)
testing.go:1446: race detected during execution of test
2023-02-06 13:49 darwin-amd64-race go@bf8d142b net/http.TestTransportCancelRequestInDo (log)
--- FAIL: TestTransportCancelRequestInDo (0.00s)
2023-02-06 13:49 darwin-amd64-race go@bf8d142b net/http.TestTransportCloseResponseBody (log)
--- FAIL: TestTransportCloseResponseBody (0.01s)
--- FAIL: TestTransportCloseResponseBody/h2 (0.16s)
testing.go:1446: race detected during execution of test
2023-02-06 18:07 darwin-amd64-race go@7c1aa5d9 net/http.TestTransportClosesRequestBody (log)
==================
WARNING: DATA RACE
Write at 0x00c002ad4000 by goroutine 18883:
runtime.slicecopy()
/tmp/buildlet/go/src/runtime/slice.go:310 +0x0
strings.(*Reader).Read()
/tmp/buildlet/go/src/strings/reader.go:44 +0xe6
net/http_test.(*countCloseReader).Read()
<autogenerated>:1 +0x74
io.copyBuffer()
...
net/http.http2ConfigureServer.func1()
/tmp/buildlet/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
/tmp/buildlet/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/tmp/buildlet/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestTransportClosesRequestBody (0.00s)
--- FAIL: TestTransportClosesRequestBody/h1 (0.02s)
testing.go:1446: race detected during execution of test
2023-02-06 18:07 darwin-amd64-race go@7c1aa5d9 net/http.TestTransportAndServerSharedBodyRace (log)
--- FAIL: TestTransportAndServerSharedBodyRace (0.03s)
--- FAIL: TestTransportAndServerSharedBodyRace/h2 (0.27s)
testing.go:1446: race detected during execution of test
2023-02-06 18:07 darwin-amd64-race go@7c1aa5d9 net/http.TestIdentityTransferEncoding (log)
--- FAIL: TestIdentityTransferEncoding (0.00s)
--- FAIL: TestIdentityTransferEncoding/h1 (0.08s)
testing.go:1446: race detected during execution of test
--- FAIL: TestIdentityTransferEncoding/h2 (0.06s)
testing.go:1446: race detected during execution of test
2023-02-06 18:07 darwin-amd64-race go@7c1aa5d9 net/http.TestTransportIgnore1xxResponses (log)
--- FAIL: TestTransportIgnore1xxResponses (0.00s)
Trybot example: https://storage.googleapis.com/go-build-log/9297dad6/linux-amd64-race_ec0c425f.log
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-07 17:08 windows-amd64-race go@9ddf748d net/http.TestOptions (log)
==================
WARNING: DATA RACE
Write at 0x00c0013c8000 by goroutine 11434:
runtime.slicecopy()
C:/workdir/go/src/runtime/slice.go:310 +0x0
net/http.(*http2dataBuffer).Read()
C:/workdir/go/src/net/http/h2_bundle.go:1105 +0x284
net/http.(*http2pipe).Read()
C:/workdir/go/src/net/http/h2_bundle.go:3678 +0x36f
net/http.(*http2requestBody).Read()
...
net/http.http2ConfigureServer.func1()
C:/workdir/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
C:/workdir/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
C:/workdir/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestOptions (0.00s)
--- FAIL: TestOptions/h1 (0.02s)
testing.go:1446: race detected during execution of test
2023-02-07 17:08 windows-amd64-race go@9ddf748d net/http.TestContentLengthZero (log)
--- FAIL: TestContentLengthZero (0.00s)
2023-02-07 17:08 windows-amd64-race go@9ddf748d net/http.TestCloseNotifier (log)
--- FAIL: TestCloseNotifier (0.00s)
2023-02-07 17:08 windows-amd64-race go@9ddf748d net/http.TestTransportPersistConnLeakNeverIdle (log)
--- FAIL: TestTransportPersistConnLeakNeverIdle (0.00s)
--- FAIL: TestTransportPersistConnLeakNeverIdle/h1 (0.63s)
testing.go:1446: race detected during execution of test
2023-02-07 17:08 windows-amd64-race go@9ddf748d net/http.TestRequestBodyLimit (log)
--- FAIL: TestRequestBodyLimit (0.00s)
--- FAIL: TestRequestBodyLimit/h1 (0.12s)
testing.go:1446: race detected during execution of test
--- FAIL: TestRequestBodyLimit/h2 (0.30s)
testing.go:1446: race detected during execution of test
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-07 22:22 freebsd-amd64-race go@9565d990 net/http.TestClientCopyHostOnRedirect (log)
==================
WARNING: DATA RACE
Write at 0x00c0020d4000 by goroutine 10809:
runtime.slicecopy()
/tmp/workdir/go/src/runtime/slice.go:310 +0x0
net/http.(*http2dataBuffer).Read()
/tmp/workdir/go/src/net/http/h2_bundle.go:1105 +0x284
net/http.(*http2pipe).Read()
/tmp/workdir/go/src/net/http/h2_bundle.go:3678 +0x36f
net/http.(*http2requestBody).Read()
...
net/http.(*conn).serve()
/tmp/workdir/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/tmp/workdir/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestClientCopyHostOnRedirect (0.00s)
--- FAIL: TestClientCopyHostOnRedirect/h2 (0.09s)
client_test.go:1551: Virtual host is 127.0.0.1:29619
client_test.go:1593: Server host is 127.0.0.1:29620
testing.go:1446: race detected during execution of test
2023-02-07 22:22 freebsd-amd64-race go@9565d990 net/http.TestTransportAndServerSharedBodyRace (log)
--- FAIL: TestTransportAndServerSharedBodyRace (0.00s)
--- FAIL: TestTransportAndServerSharedBodyRace/h2 (0.17s)
testing.go:1446: race detected during execution of test
--- FAIL: TestTransportAndServerSharedBodyRace/h1 (0.18s)
testing.go:1446: race detected during execution of test
2023-02-07 22:22 freebsd-amd64-race go@9565d990 net/http.TestHTTP10ConnectionHeader (log)
--- FAIL: TestHTTP10ConnectionHeader (0.00s)
2023-02-07 22:22 freebsd-amd64-race go@9565d990 net/http.TestServerReaderFromOrder (log)
--- FAIL: TestServerReaderFromOrder (0.00s)
--- FAIL: TestServerReaderFromOrder/h1 (0.20s)
testing.go:1446: race detected during execution of test
--- FAIL: TestServerReaderFromOrder/h2 (0.24s)
testing.go:1446: race detected during execution of test
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-08 14:52 linux-amd64-race go@1a09d57d net/http.TestCloseNotifier (log)
==================
WARNING: DATA RACE
Write at 0x00c00080a000 by goroutine 14761:
runtime.slicecopy()
/workdir/go/src/runtime/slice.go:310 +0x0
net/http.(*http2dataBuffer).Read()
/workdir/go/src/net/http/h2_bundle.go:1105 +0x284
net/http.(*http2pipe).Read()
/workdir/go/src/net/http/h2_bundle.go:3678 +0x36f
net/http.http2transportResponseBody.Read()
...
net/http.(*http2Server).ServeConn()
/workdir/go/src/net/http/h2_bundle.go:4270 +0x183d
net/http.http2ConfigureServer.func1()
/workdir/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestCloseNotifier (0.00s)
2023-02-08 14:52 linux-amd64-race go@1a09d57d net/http.TestServerRequestContextCancel_ServeHTTPDone (log)
--- FAIL: TestServerRequestContextCancel_ServeHTTPDone (0.00s)
--- FAIL: TestServerRequestContextCancel_ServeHTTPDone/h2 (0.05s)
testing.go:1446: race detected during execution of test
--- FAIL: TestServerRequestContextCancel_ServeHTTPDone/h1 (0.04s)
testing.go:1446: race detected during execution of test
2023-02-08 14:52 linux-amd64-race go@1a09d57d net/http.TestHandlerPanicWithHijack (log)
--- FAIL: TestHandlerPanicWithHijack (0.00s)
2023-02-08 14:52 linux-amd64-race go@1a09d57d net/http.TestTimeoutHandlerRace (log)
--- FAIL: TestTimeoutHandlerRace (0.00s)
--- FAIL: TestTimeoutHandlerRace/h2 (0.18s)
testing.go:1446: race detected during execution of test
2023-02-08 14:52 linux-amd64-race go@1a09d57d net/http.TestHijackBeforeRequestBodyRead (log)
--- FAIL: TestHijackBeforeRequestBodyRead (0.00s)
--- FAIL: TestHijackBeforeRequestBodyRead/h1 (0.19s)
testing.go:1446: race detected during execution of test
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-08 18:28 darwin-amd64-race go@da937660 net/http.TestTLSHandshakeTrace (log)
==================
WARNING: DATA RACE
Write at 0x00c000d66000 by goroutine 5162:
net/http_test.neverEnding.Read()
/tmp/buildlet/go/src/net/http/serve_test.go:3010 +0x6f
net/http_test.(*neverEnding).Read()
<autogenerated>:1 +0x1f
io.copyBuffer()
/tmp/buildlet/go/src/io/io.go:428 +0x2c8
io.Copy()
...
net/http.http2ConfigureServer.func1()
/tmp/buildlet/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
/tmp/buildlet/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/tmp/buildlet/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestTLSHandshakeTrace (0.00s)
--- FAIL: TestTLSHandshakeTrace/h2 (0.09s)
testing.go:1446: race detected during execution of test
2023-02-08 18:28 darwin-amd64-race go@da937660 net/http.TestIssue4191_InfiniteGetTimeout (log)
--- FAIL: TestIssue4191_InfiniteGetTimeout (0.00s)
--- FAIL: TestIssue4191_InfiniteGetTimeout/h2 (0.12s)
testing.go:1446: race detected during execution of test
2023-02-08 18:28 darwin-amd64-race go@da937660 net/http.TestIssue32441 (log)
--- FAIL: TestIssue32441 (0.00s)
2023-02-08 18:28 darwin-amd64-race go@da937660 net/http.TestTransportDialTLS (log)
--- FAIL: TestTransportDialTLS (0.00s)
--- FAIL: TestTransportDialTLS/h2 (0.08s)
testing.go:1446: race detected during execution of test
2023-02-08 18:28 darwin-amd64-race go@da937660 net/http.TestCancelRequestWithChannelBeforeDo_Context (log)
--- FAIL: TestCancelRequestWithChannelBeforeDo_Context (0.00s)
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-08 14:52 linux-amd64-longtest-race go@1a09d57d net/http.TestIssue4191_InfiniteGetToPutTimeout (log)
==================
WARNING: DATA RACE
Write at 0x00c00040a000 by goroutine 23452:
runtime.slicecopy()
/workdir/go/src/runtime/slice.go:310 +0x0
bufio.(*Reader).Read()
/workdir/go/src/bufio/bufio.go:250 +0x6b7
net/http/internal.(*chunkedReader).Read()
/workdir/go/src/net/http/internal/chunked.go:109 +0x371
net/http.(*body).readLocked()
...
/workdir/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestIssue4191_InfiniteGetToPutTimeout (0.51s)
--- FAIL: TestIssue4191_InfiniteGetToPutTimeout/h1 (0.51s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-09 09:33 windows-amd64-race go@fd208c88 net/http.TestServeFileFromCWD (log)
==================
WARNING: DATA RACE
Write at 0x00c00283c000 by goroutine 3225:
runtime.slicecopy()
C:/workdir/go/src/runtime/slice.go:310 +0x0
net/http.(*http2dataBuffer).Read()
C:/workdir/go/src/net/http/h2_bundle.go:1105 +0x284
net/http.(*http2pipe).Read()
C:/workdir/go/src/net/http/h2_bundle.go:3678 +0x36f
net/http.http2transportResponseBody.Read()
...
net/http.(*http2Server).ServeConn()
C:/workdir/go/src/net/http/h2_bundle.go:4270 +0x183d
net/http.http2ConfigureServer.func1()
C:/workdir/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
C:/workdir/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
C:/workdir/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestServeFileFromCWD (0.00s)
2023-02-09 09:33 windows-amd64-race go@fd208c88 net/http.TestClientTimeout_Headers (log)
--- FAIL: TestClientTimeout_Headers (0.00s)
--- FAIL: TestClientTimeout_Headers/h1 (0.04s)
testing.go:1446: race detected during execution of test
2023-02-09 09:33 windows-amd64-race go@fd208c88 net/http.TestClientWrites (log)
--- FAIL: TestClientWrites (0.00s)
2023-02-09 09:33 windows-amd64-race go@fd208c88 net/http.TestOmitHTTP2Vet (log)
--- FAIL: TestOmitHTTP2Vet (7.40s)
testing.go:1446: race detected during execution of test
2023-02-09 09:33 windows-amd64-race go@fd208c88 net/http.TestClientCopyHeadersOnRedirect (log)
--- FAIL: TestClientCopyHeadersOnRedirect (0.00s)
--- FAIL: TestClientCopyHeadersOnRedirect/h2 (0.09s)
client_test.go:1535: result = "got errors"; want ok
testing.go:1446: race detected during execution of test
--- FAIL: TestClientCopyHeadersOnRedirect/h1 (0.11s)
client_test.go:1535: result = "got errors"; want ok
testing.go:1446: race detected during execution of test
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-09 23:41 windows-amd64-race go@fb79da29 net/http.TestTransportRemovesH2ConnsAfterIdle (log)
==================
WARNING: DATA RACE
Write at 0x00c000fec000 by goroutine 12003:
net/http_test.neverEnding.Read()
C:/workdir/go/src/net/http/serve_test.go:3010 +0x6f
net/http_test.(*neverEnding).Read()
<autogenerated>:1 +0x1f
io.copyBuffer()
C:/workdir/go/src/io/io.go:428 +0x2c8
io.Copy()
...
net/http.(*http2Server).ServeConn()
C:/workdir/go/src/net/http/h2_bundle.go:4270 +0x183d
net/http.http2ConfigureServer.func1()
C:/workdir/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
C:/workdir/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
C:/workdir/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestTransportRemovesH2ConnsAfterIdle (0.00s)
2023-02-09 23:41 windows-amd64-race go@fb79da29 net/http.TestIssue4191_InfiniteGetToPutTimeout (log)
--- FAIL: TestIssue4191_InfiniteGetToPutTimeout (0.00s)
--- FAIL: TestIssue4191_InfiniteGetToPutTimeout/h1 (0.11s)
testing.go:1446: race detected during execution of test
2023-02-09 23:41 windows-amd64-race go@fb79da29 net/http.TestTransportContentEncodingCaseInsensitive (log)
--- FAIL: TestTransportContentEncodingCaseInsensitive (0.00s)
--- FAIL: TestTransportContentEncodingCaseInsensitive/h2 (0.11s)
--- FAIL: TestTransportContentEncodingCaseInsensitive/h2/GZIP (0.06s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
--- FAIL: TestTransportContentEncodingCaseInsensitive/h1 (0.11s)
--- FAIL: TestTransportContentEncodingCaseInsensitive/h1/GZIP (0.06s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
2023-02-09 23:41 windows-amd64-race go@fb79da29 net/http.TestIssue4191_InfiniteGetTimeout (log)
--- FAIL: TestIssue4191_InfiniteGetTimeout (0.00s)
--- FAIL: TestIssue4191_InfiniteGetTimeout/h1 (0.07s)
testing.go:1446: race detected during execution of test
2023-02-09 23:41 windows-amd64-race go@fb79da29 net/http.TestTransportProxyGetConnectHeader (log)
--- FAIL: TestTransportProxyGetConnectHeader (0.00s)
The test race failures should be “fixed” (re-buried) as of CL 467095.
#58446 describes the underlying cause of the failures, and has a lot less watchflakes noise.
@neild, should we close this as a dup of #58446?
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-10 15:04 freebsd-amd64-race go@79e01ab7 net/http.TestContentEncodingNoSniffing (log)
==================
WARNING: DATA RACE
Write at 0x00c0025ee000 by goroutine 11872:
runtime.racewriterange()
<autogenerated>:1 +0x24
internal/poll.ignoringEINTRIO()
/tmp/workdir/go/src/internal/poll/fd_unix.go:793 +0x419
internal/poll.(*FD).Read()
/tmp/workdir/go/src/internal/poll/fd_unix.go:163 +0x22
net.(*netFD).Read()
...
==================
--- FAIL: TestContentEncodingNoSniffing (0.00s)
--- FAIL: TestContentEncodingNoSniffing/h1 (0.20s)
--- FAIL: TestContentEncodingNoSniffing/h1/empty_but_set_content-encoding (0.04s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
--- FAIL: TestContentEncodingNoSniffing/h2 (0.19s)
--- FAIL: TestContentEncodingNoSniffing/h2/empty_but_set_content-encoding (0.04s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
2023-02-10 15:04 freebsd-amd64-race go@79e01ab7 net/http.TestFileServerZeroByte (log)
--- FAIL: TestFileServerZeroByte (0.00s)
2023-02-10 15:04 freebsd-amd64-race go@79e01ab7 net/http.TestFileServerNamesEscape (log)
--- FAIL: TestFileServerNamesEscape (0.00s)
--- FAIL: TestFileServerNamesEscape/h2 (0.04s)
testing.go:1446: race detected during execution of test
--- FAIL: TestFileServerNamesEscape/h1 (0.05s)
testing.go:1446: race detected during execution of test
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-10 22:09 windows-amd64-race go@5c5f8dc9 net/http.TestTransportAndServerSharedBodyRace (log)
==================
WARNING: DATA RACE
Write at 0x00c000bd8000 by goroutine 6921:
io.copyBuffer()
C:/workdir/go/src/io/io.go:436 +0x386
io.Copy()
C:/workdir/go/src/io/io.go:387 +0xce
io.CopyN()
C:/workdir/go/src/io/io.go:363 +0xb0
net/http_test.testTransportAndServerSharedBodyRace.func2.1()
...
net/http.(*conn).serve()
C:/workdir/go/src/net/http/server.go:1903 +0x1c01
net/http.(*Server).Serve.func3()
C:/workdir/go/src/net/http/server.go:3089 +0x4f
==================
--- FAIL: TestTransportAndServerSharedBodyRace (0.00s)
--- FAIL: TestTransportAndServerSharedBodyRace/h1 (0.20s)
testing.go:1446: race detected during execution of test
--- FAIL: TestTransportAndServerSharedBodyRace/h2 (0.20s)
testing.go:1446: race detected during execution of test
2023-02-10 22:09 windows-amd64-race go@5c5f8dc9 net/http.TestTrailersClientToServer (log)
--- FAIL: TestTrailersClientToServer (0.00s)
2023-02-10 22:09 windows-amd64-race go@5c5f8dc9 net/http.TestClientInsecureTransport (log)
--- FAIL: TestClientInsecureTransport (0.00s)
--- FAIL: TestClientInsecureTransport/h2 (0.14s)
testing.go:1446: race detected during execution of test
--- FAIL: TestClientInsecureTransport/https1 (0.11s)
testing.go:1446: race detected during execution of test
2023-02-10 22:09 windows-amd64-race go@5c5f8dc9 net/http.TestClientWrites (log)
--- FAIL: TestClientWrites (0.00s)
2023-02-10 22:09 windows-amd64-race go@5c5f8dc9 net/http.TestServerRequestContextCancel_ConnClose (log)
--- FAIL: TestServerRequestContextCancel_ConnClose (0.00s)
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-10 22:09 linux-amd64-race go@5c5f8dc9 net/http.TestIssue4191_InfiniteGetTimeout (log)
==================
WARNING: DATA RACE
Write at 0x00c00200e000 by goroutine 8517:
io.copyBuffer()
/workdir/go/src/io/io.go:436 +0x386
io.Copy()
/workdir/go/src/io/io.go:387 +0x57
net/http_test.testIssue4191_InfiniteGetTimeout.func1()
/workdir/go/src/net/http/transport_test.go:2229 +0x13
net/http.HandlerFunc.ServeHTTP()
...
net/http.http2ConfigureServer.func1()
/workdir/go/src/net/http/h2_bundle.go:4128 +0x11e
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1903 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3089 +0x4f
==================
--- FAIL: TestIssue4191_InfiniteGetTimeout (0.00s)
--- FAIL: TestIssue4191_InfiniteGetTimeout/h2 (0.06s)
testing.go:1446: race detected during execution of test
2023-02-10 22:09 linux-amd64-race go@5c5f8dc9 net/http.TestServerDuplicateBackgroundRead (log)
--- FAIL: TestServerDuplicateBackgroundRead (0.00s)
2023-02-10 22:09 linux-amd64-race go@5c5f8dc9 net/http.TestZeroLengthPostAndResponse (log)
--- FAIL: TestZeroLengthPostAndResponse (0.00s)
--- FAIL: TestZeroLengthPostAndResponse/h2 (0.05s)
testing.go:1446: race detected during execution of test
--- FAIL: TestZeroLengthPostAndResponse/h1 (0.08s)
testing.go:1446: race detected during execution of test
2023-02-10 22:09 linux-amd64-race go@5c5f8dc9 net/http.TestCancelRequestWithChannelBeforeDo_Context (log)
--- FAIL: TestCancelRequestWithChannelBeforeDo_Context (0.00s)
2023-02-10 22:09 linux-amd64-race go@5c5f8dc9 net/http.TestTransportLimits1xxResponses (log)
--- FAIL: TestTransportLimits1xxResponses (0.00s)
2023-02-10 22:21 linux-amd64-race go@bd5de19b net/http.TestIssue4191_InfiniteGetTimeout (log)
==================
WARNING: DATA RACE
Write at 0x00c001a66000 by goroutine 6453:
io.copyBuffer()
/workdir/go/src/io/io.go:436 +0x386
io.Copy()
/workdir/go/src/io/io.go:387 +0x57
net/http_test.testIssue4191_InfiniteGetTimeout.func1()
/workdir/go/src/net/http/transport_test.go:2229 +0x13
net/http.HandlerFunc.ServeHTTP()
...
net/http.http2ConfigureServer.func1()
/workdir/go/src/net/http/h2_bundle.go:4128 +0x11e
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1903 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3089 +0x4f
==================
--- FAIL: TestIssue4191_InfiniteGetTimeout (0.00s)
--- FAIL: TestIssue4191_InfiniteGetTimeout/h1 (0.08s)
testing.go:1446: race detected during execution of test
2023-02-10 22:21 linux-amd64-race go@bd5de19b net/http.TestTransportRejectsSignInContentLength (log)
--- FAIL: TestTransportRejectsSignInContentLength (0.00s)
2023-02-10 22:21 linux-amd64-race go@bd5de19b net/http.TestTransportClosesBodyOnInvalidRequests (log)
--- FAIL: TestTransportClosesBodyOnInvalidRequests (0.00s)
--- FAIL: TestTransportClosesBodyOnInvalidRequests/h1 (0.04s)
testing.go:1446: race detected during execution of test
2023-02-10 22:21 linux-amd64-race go@bd5de19b net/http.TestTransportMaxConnsPerHost (log)
--- FAIL: TestTransportMaxConnsPerHost (0.00s)
--- FAIL: TestTransportMaxConnsPerHost/h1 (0.10s)
testing.go:1446: race detected during execution of test
--- FAIL: TestTransportMaxConnsPerHost/https1 (0.09s)
testing.go:1446: race detected during execution of test
--- FAIL: TestTransportMaxConnsPerHost/h2 (0.10s)
testing.go:1446: race detected during execution of test
2023-02-11 09:26 linux-amd64-race go@e03ee85e net/http.TestTransportAndServerSharedBodyRace (log)
==================
WARNING: DATA RACE
Write at 0x00c000b9c000 by goroutine 5133:
io.copyBuffer()
/workdir/go/src/io/io.go:436 +0x386
io.Copy()
/workdir/go/src/io/io.go:387 +0xce
io.CopyN()
/workdir/go/src/io/io.go:363 +0xb0
net/http_test.testTransportAndServerSharedBodyRace.func2.1()
...
net/http.http2ConfigureServer.func1()
/workdir/go/src/net/http/h2_bundle.go:4128 +0x11e
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1903 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3089 +0x4f
==================
--- FAIL: TestTransportAndServerSharedBodyRace (0.00s)
--- FAIL: TestTransportAndServerSharedBodyRace/h1 (0.16s)
testing.go:1446: race detected during execution of test
2023-02-11 09:26 linux-amd64-race go@e03ee85e net/http.TestTransportProxyDialDoesNotMutateProxyConnectHeader (log)
--- FAIL: TestTransportProxyDialDoesNotMutateProxyConnectHeader (0.00s)
--- FAIL: TestTransportProxyDialDoesNotMutateProxyConnectHeader/h1 (0.06s)
clientserver_test.go:210: server log: http2: server: error reading preface from client 127.0.0.1:42892: bogus greeting "CONNECT golang.fake.tld:"
testing.go:1446: race detected during execution of test
2023-02-11 09:26 linux-amd64-race go@e03ee85e net/http.TestHeadBody (log)
--- FAIL: TestHeadBody (0.00s)
--- FAIL: TestHeadBody/h2 (0.10s)
--- FAIL: TestHeadBody/h2/chunked (0.05s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
--- FAIL: TestHeadBody/h1 (0.10s)
--- FAIL: TestHeadBody/h1/chunked (0.06s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
2023-02-11 09:26 linux-amd64-race go@e03ee85e net/http.TestTransportRespectRequestWantsClose (log)
--- FAIL: TestTransportRespectRequestWantsClose (0.00s)
2023-02-11 09:26 linux-amd64-race go@e03ee85e net/http.TestTransportRangeAndGzip (log)
--- FAIL: TestTransportRangeAndGzip (0.00s)
--- FAIL: TestTransportRangeAndGzip/h1 (0.05s)
testing.go:1446: race detected during execution of test
--- FAIL: TestTransportRangeAndGzip/h2 (0.05s)
testing.go:1446: race detected during execution of test
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-11 09:26 linux-amd64-longtest-race go@e03ee85e net/http.TestServeFileFromCWD (log)
==================
WARNING: DATA RACE
Write at 0x00c000390000 by goroutine 5440:
io.copyBuffer()
/workdir/go/src/io/io.go:436 +0x386
io.Copy()
/workdir/go/src/io/io.go:387 +0xce
io.CopyN()
/workdir/go/src/io/io.go:363 +0xb0
net/http.serveContent()
...
/workdir/go/src/net/http/h2_bundle.go:4128 +0x11e
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1903 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3089 +0x4f
==================
--- FAIL: TestServeFileFromCWD (0.04s)
--- FAIL: TestServeFileFromCWD/h2 (0.03s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
I'm hitting this repeatedly on TryBots even if I'm rebased on latest master.
https://storage.googleapis.com/go-build-log/d6a16255/linux-amd64-race_6d494f2b.log https://go-review.googlesource.com/c/go/+/460542
Change https://go.dev/cl/467895 mentions this issue: Revert "io: detect Writers that access io.Copy's buffer after returning"
I'm hitting this repeatedly on TryBots even if I'm rebased on latest master.
Sorry about that. Rolling back https://go.dev/cl/466865 until I figure out what new race condition is being triggered here.
@FiloSottile, the stack trace from that log doesn't match the h2_bundle.go in CL 467657, and the build dashboard doesn't show any -race failures after that CL.
When you say “rebased on latest master”, exactly which commit had you rebased on?
It looks like the last TryBot run on CL 460542 was on PS4, parented to commit 261fe25c83a94fc3defe064baed3944cd3d16959, which does indeed predate the net/http fix in CL 467657.
I had checked that it was more recent than the CL mentioned in https://github.com/golang/go/issues/58168#issuecomment-1426118796 but it's entirely possible I got confused, sorry about that! I re-rebased while commenting but then failed to vote Run-TryBot+1.
Indeed, TryBots passed, sorry for the noise!
Found new dashboard test flakes for:
#!watchflakes
post <- pkg == "net/http" && log ~ `DATA RACE` && log ~ `net/http\.\(\*http2Framer\)\.WriteDataPadded`
2023-02-02 15:35 darwin-amd64-race go@53372ab2 net/http.TestServeFileFromCWD (log)
==================
WARNING: DATA RACE
Write at 0x00c000ba0000 by goroutine 7598:
runtime.racewriterange()
<autogenerated>:1 +0x24
internal/poll.ignoringEINTRIO()
/tmp/buildlet/go/src/internal/poll/fd_unix.go:793 +0x419
internal/poll.(*FD).Read()
/tmp/buildlet/go/src/internal/poll/fd_unix.go:163 +0x22
os.(*File).read()
...
net/http.http2ConfigureServer.func1()
/tmp/buildlet/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
/tmp/buildlet/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/tmp/buildlet/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestServeFileFromCWD (0.04s)
--- FAIL: TestServeFileFromCWD/h1 (0.11s)
testing.go:1446: race detected during execution of test
2023-02-02 15:35 darwin-amd64-race go@53372ab2 net/http.TestFileServerSortsNames (log)
--- FAIL: TestFileServerSortsNames (0.03s)
--- FAIL: TestFileServerSortsNames/h1 (0.14s)
testing.go:1446: race detected during execution of test
2023-02-02 15:35 darwin-amd64-race go@53372ab2 net/http.TestFSRedirect (log)
--- FAIL: TestFSRedirect (0.03s)
--- FAIL: TestFSRedirect/h2 (0.09s)
testing.go:1446: race detected during execution of test
2023-02-02 15:35 darwin-amd64-race go@53372ab2 net/http.TestFileServerEscapesNames (log)
--- FAIL: TestFileServerEscapesNames (0.05s)
2023-02-02 15:35 darwin-amd64-race go@53372ab2 net/http.TestFileServerImplicitLeadingSlash (log)
--- FAIL: TestFileServerImplicitLeadingSlash (0.02s)
2023-02-06 20:53 darwin-amd64-race go@b46e44a3 net/http.TestIssue3595 (log)
==================
WARNING: DATA RACE
Write at 0x00c0007c2000 by goroutine 17688:
runtime.slicecopy()
/tmp/buildlet/go/src/runtime/slice.go:310 +0x0
bufio.(*Reader).Read()
/tmp/buildlet/go/src/bufio/bufio.go:250 +0x6b7
net/http/internal.(*chunkedReader).Read()
/tmp/buildlet/go/src/net/http/internal/chunked.go:109 +0x371
net/http.(*body).readLocked()
...
net/http.http2ConfigureServer.func1()
/tmp/buildlet/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
/tmp/buildlet/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/tmp/buildlet/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestIssue3595 (0.00s)
--- FAIL: TestIssue3595/h2 (0.09s)
testing.go:1446: race detected during execution of test
2023-02-06 20:53 darwin-amd64-race go@b46e44a3 net/http.TestTransportPrefersResponseOverWriteError (log)
--- FAIL: TestTransportPrefersResponseOverWriteError (0.00s)
2023-02-06 20:53 darwin-amd64-race go@b46e44a3 net/http.TestTransportTreat101Terminal (log)
--- FAIL: TestTransportTreat101Terminal (0.00s)
2023-02-06 20:53 darwin-amd64-race go@b46e44a3 net/http.TestTLSHandshakeTrace (log)
--- FAIL: TestTLSHandshakeTrace (0.00s)
--- FAIL: TestTLSHandshakeTrace/https1 (0.12s)
testing.go:1446: race detected during execution of test
--- FAIL: TestTLSHandshakeTrace/h2 (0.13s)
testing.go:1446: race detected during execution of test
2023-02-06 20:53 darwin-amd64-race go@b46e44a3 net/http.TestIssue4191_InfiniteGetToPutTimeout (log)
--- FAIL: TestIssue4191_InfiniteGetToPutTimeout (0.00s)
--- FAIL: TestIssue4191_InfiniteGetToPutTimeout/h1 (0.13s)
testing.go:1446: race detected during execution of test
2023-02-06 20:56 linux-amd64-longtest-race go@e2ca417e net/http.TestIssue4191_InfiniteGetToPutTimeout (log)
==================
WARNING: DATA RACE
Write at 0x00c00059e000 by goroutine 23513:
net/http_test.neverEnding.Read()
/workdir/go/src/net/http/serve_test.go:3010 +0x6f
net/http_test.(*neverEnding).Read()
<autogenerated>:1 +0x1f
io.copyBuffer()
/workdir/go/src/io/io.go:428 +0x2c8
io.Copy()
...
/workdir/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestIssue4191_InfiniteGetToPutTimeout (0.51s)
--- FAIL: TestIssue4191_InfiniteGetToPutTimeout/h1 (0.51s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
2023-02-07 23:37 windows-amd64-race go@f63ee8b2 net/http.TestChunkedNoContent (log)
==================
WARNING: DATA RACE
Write at 0x00c000d9a000 by goroutine 5609:
net/http_test.neverEnding.Read()
C:/workdir/go/src/net/http/serve_test.go:3010 +0x6f
net/http_test.(*neverEnding).Read()
<autogenerated>:1 +0x1f
io.copyBuffer()
C:/workdir/go/src/io/io.go:428 +0x2c8
io.Copy()
...
net/http.http2ConfigureServer.func1()
C:/workdir/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
C:/workdir/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
C:/workdir/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestChunkedNoContent (0.00s)
--- FAIL: TestChunkedNoContent/h2 (0.06s)
testing.go:1446: race detected during execution of test
2023-02-07 23:37 windows-amd64-race go@f63ee8b2 net/http.TestServeWithSlashRedirectKeepsQueryString (log)
--- FAIL: TestServeWithSlashRedirectKeepsQueryString (0.00s)
2023-02-07 23:37 windows-amd64-race go@f63ee8b2 net/http.TestServerNoDate (log)
--- FAIL: TestServerNoDate (0.00s)
2023-02-07 23:37 windows-amd64-race go@f63ee8b2 net/http.TestTransportConnectionCloseOnRequestDisableKeepAlive (log)
--- FAIL: TestTransportConnectionCloseOnRequestDisableKeepAlive (0.00s)
2023-02-07 23:37 windows-amd64-race go@f63ee8b2 net/http.TestServerWriteTimeout (log)
--- FAIL: TestServerWriteTimeout (0.00s)
--- FAIL: TestServerWriteTimeout/h2 (0.18s)
clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:50801: write tcp 127.0.0.1:50798->127.0.0.1:50801: i/o timeout
serve_test.go:784: Get error, retrying: Get "https://127.0.0.1:50798": EOF
clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:50805: write tcp 127.0.0.1:50804->127.0.0.1:50805: i/o timeout
serve_test.go:784: Get error, retrying: Get "https://127.0.0.1:50804": EOF
clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:50809: write tcp 127.0.0.1:50808->127.0.0.1:50809: i/o timeout
serve_test.go:784: Get error, retrying: Get "https://127.0.0.1:50808": EOF
testing.go:1446: race detected during execution of test
--- FAIL: TestServerWriteTimeout/h1 (0.31s)
clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:50800: write tcp 127.0.0.1:50799->127.0.0.1:50800: i/o timeout
serve_test.go:784: Get error, retrying: Get "https://127.0.0.1:50799": EOF
clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:50807: read tcp 127.0.0.1:50806->127.0.0.1:50807: i/o timeout
serve_test.go:784: Get error, retrying: Get "https://127.0.0.1:50806": write tcp 127.0.0.1:50807->127.0.0.1:50806: wsasend: An established connection was aborted by the software in your host machine.
clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:50813: write tcp 127.0.0.1:50810->127.0.0.1:50813: i/o timeout
serve_test.go:784: Get error, retrying: Get "https://127.0.0.1:50810": EOF
clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:50825: read tcp 127.0.0.1:50824->127.0.0.1:50825: i/o timeout
serve_test.go:784: Get error, retrying: Get "https://127.0.0.1:50824": write tcp 127.0.0.1:50825->127.0.0.1:50824: wsasend: An established connection was aborted by the software in your host machine.
testing.go:1446: race detected during execution of test
2023-02-09 20:47 darwin-amd64-race go@d57ebde9 net/http.TestIssue4191_InfiniteGetTimeout (log)
==================
WARNING: DATA RACE
Write at 0x00c0005de000 by goroutine 1940:
net/http_test.neverEnding.Read()
/tmp/buildlet/go/src/net/http/serve_test.go:3010 +0x6f
net/http_test.(*neverEnding).Read()
<autogenerated>:1 +0x1f
io.copyBuffer()
/tmp/buildlet/go/src/io/io.go:428 +0x2c8
io.Copy()
...
net/http.http2ConfigureServer.func1()
/tmp/buildlet/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
/tmp/buildlet/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/tmp/buildlet/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestIssue4191_InfiniteGetTimeout (0.00s)
--- FAIL: TestIssue4191_InfiniteGetTimeout/h1 (0.70s)
testing.go:1446: race detected during execution of test
2023-02-09 20:47 darwin-amd64-race go@d57ebde9 net/http.TestUnsupportedTransferEncodingsReturn501 (log)
--- FAIL: TestUnsupportedTransferEncodingsReturn501 (0.00s)
2023-02-09 20:47 darwin-amd64-race go@d57ebde9 net/http.TestHandlerBodyClose (log)
--- FAIL: TestHandlerBodyClose (2.68s)
testing.go:1446: race detected during execution of test
2023-02-09 20:47 darwin-amd64-race go@d57ebde9 net/http.TestChunkedNoContent (log)
--- FAIL: TestChunkedNoContent (0.00s)
2023-02-09 20:47 darwin-amd64-race go@d57ebde9 net/http.TestTransportDialTLS (log)
--- FAIL: TestTransportDialTLS (0.00s)
2023-02-09 21:13 darwin-amd64-race go@da47cd61 net/http.TestServerContext_LocalAddrContextKey (log)
==================
WARNING: DATA RACE
Write at 0x00c00083a000 by goroutine 3954:
runtime.slicecopy()
/tmp/buildlet/go/src/runtime/slice.go:310 +0x0
net/http.(*http2dataBuffer).Read()
/tmp/buildlet/go/src/net/http/h2_bundle.go:1105 +0x284
net/http.(*http2pipe).Read()
/tmp/buildlet/go/src/net/http/h2_bundle.go:3678 +0x36f
net/http.(*http2requestBody).Read()
...
net/http.(*conn).serve()
/tmp/buildlet/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/tmp/buildlet/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestServerContext_LocalAddrContextKey (0.01s)
--- FAIL: TestServerContext_LocalAddrContextKey/h2 (0.19s)
testing.go:1446: race detected during execution of test
--- FAIL: TestServerContext_LocalAddrContextKey/h1 (0.40s)
testing.go:1446: race detected during execution of test
2023-02-09 21:13 darwin-amd64-race go@da47cd61 net/http.TestTransportRejectsSignInContentLength (log)
--- FAIL: TestTransportRejectsSignInContentLength (0.01s)
2023-02-09 21:13 darwin-amd64-race go@da47cd61 net/http.TestTransportAndServerSharedBodyRace (log)
--- FAIL: TestTransportAndServerSharedBodyRace (0.12s)
--- FAIL: TestTransportAndServerSharedBodyRace/h1 (0.97s)
testing.go:1446: race detected during execution of test
--- FAIL: TestTransportAndServerSharedBodyRace/h2 (1.12s)
testing.go:1446: race detected during execution of test
2023-02-09 21:13 darwin-amd64-race go@da47cd61 net/http.TestTransportRespectRequestWantsClose (log)
--- FAIL: TestTransportRespectRequestWantsClose (0.03s)
2023-02-10 14:29 windows-amd64-race go@7d57a9ce net/http.TestIssue4191_InfiniteGetTimeout (log)
==================
WARNING: DATA RACE
Write at 0x00c000fb6000 by goroutine 11058:
net/http_test.neverEnding.Read()
C:/workdir/go/src/net/http/serve_test.go:3010 +0x6f
net/http_test.(*neverEnding).Read()
<autogenerated>:1 +0x1f
io.copyBuffer()
C:/workdir/go/src/io/io.go:428 +0x2c8
io.Copy()
...
net/http.http2ConfigureServer.func1()
C:/workdir/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
C:/workdir/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
C:/workdir/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestIssue4191_InfiniteGetTimeout (0.00s)
--- FAIL: TestIssue4191_InfiniteGetTimeout/h1 (0.08s)
testing.go:1446: race detected during execution of test
2023-02-10 14:29 windows-amd64-race go@7d57a9ce net/http.TestResponseControllerSetFutureReadDeadline (log)
--- FAIL: TestResponseControllerSetFutureReadDeadline (0.00s)
--- FAIL: TestResponseControllerSetFutureReadDeadline/h2 (0.07s)
testing.go:1446: race detected during execution of test
--- FAIL: TestResponseControllerSetFutureReadDeadline/h1 (0.07s)
testing.go:1446: race detected during execution of test
2023-02-10 14:29 windows-amd64-race go@7d57a9ce net/http.TestResponseControllerHijack (log)
--- FAIL: TestResponseControllerHijack (0.00s)
2023-02-10 14:29 windows-amd64-race go@7d57a9ce net/http.TestHijackBeforeRequestBodyRead (log)
--- FAIL: TestHijackBeforeRequestBodyRead (0.00s)
2023-02-10 14:29 windows-amd64-race go@7d57a9ce net/http.TestResponseControllerSetPastReadDeadline (log)
--- FAIL: TestResponseControllerSetPastReadDeadline (0.00s)
2023-02-10 16:32 darwin-amd64-race go@6e5c2608 net/http.TestServerIssue5953 (log)
==================
WARNING: DATA RACE
Write at 0x00c000b74000 by goroutine 13289:
net/http_test.neverEnding.Read()
/tmp/buildlet/go/src/net/http/serve_test.go:3010 +0x6f
net/http_test.(*neverEnding).Read()
<autogenerated>:1 +0x1f
io.copyBuffer()
/tmp/buildlet/go/src/io/io.go:428 +0x2c8
io.Copy()
...
net/http.http2ConfigureServer.func1()
/tmp/buildlet/go/src/net/http/h2_bundle.go:4060 +0x11e
net/http.(*conn).serve()
/tmp/buildlet/go/src/net/http/server.go:1892 +0x1c01
net/http.(*Server).Serve.func3()
/tmp/buildlet/go/src/net/http/server.go:3078 +0x4f
==================
--- FAIL: TestServerIssue5953 (0.00s)
--- FAIL: TestServerIssue5953/h1 (0.16s)
testing.go:1446: race detected during execution of test
2023-02-10 16:32 darwin-amd64-race go@6e5c2608 net/http.TestDisableKeepAliveUpgrade (log)
--- FAIL: TestDisableKeepAliveUpgrade (0.00s)
2023-02-10 16:32 darwin-amd64-race go@6e5c2608 net/http.TestTransportClosesBodyOnError (log)
--- FAIL: TestTransportClosesBodyOnError (0.00s)
--- FAIL: TestTransportClosesBodyOnError/h1 (0.24s)
testing.go:1446: race detected during execution of test
--- FAIL: TestTransportClosesBodyOnError/h2 (0.23s)
testing.go:1446: race detected during execution of test
2023-02-10 16:32 darwin-amd64-race go@6e5c2608 net/http.TestIssue4191_InfiniteGetTimeout (log)
--- FAIL: TestIssue4191_InfiniteGetTimeout (0.00s)
--- FAIL: TestIssue4191_InfiniteGetTimeout/h2 (0.22s)
testing.go:1446: race detected during execution of test
2023-02-10 16:32 darwin-amd64-race go@6e5c2608 net/http.TestCaseSensitiveMethod (log)
--- FAIL: TestCaseSensitiveMethod (0.00s)
2023-02-10 22:09 darwin-amd64-race go@5c5f8dc9 net/http.TestTransportAndServerSharedBodyRace (log)
==================
WARNING: DATA RACE
Write at 0x00c000a0e000 by goroutine 3213:
io.copyBuffer()
/tmp/buildlet/go/src/io/io.go:436 +0x386
io.Copy()
/tmp/buildlet/go/src/io/io.go:387 +0xce
io.CopyN()
/tmp/buildlet/go/src/io/io.go:363 +0xb0
net/http_test.testTransportAndServerSharedBodyRace.func2.1()
...
net/http.http2ConfigureServer.func1()
/tmp/buildlet/go/src/net/http/h2_bundle.go:4128 +0x11e
net/http.(*conn).serve()
/tmp/buildlet/go/src/net/http/server.go:1903 +0x1c01
net/http.(*Server).Serve.func3()
/tmp/buildlet/go/src/net/http/server.go:3089 +0x4f
==================
--- FAIL: TestTransportAndServerSharedBodyRace (0.07s)
--- FAIL: TestTransportAndServerSharedBodyRace/h1 (1.18s)
testing.go:1446: race detected during execution of test
2023-02-10 22:09 darwin-amd64-race go@5c5f8dc9 net/http.TestServerReaderFromOrder (log)
--- FAIL: TestServerReaderFromOrder (0.01s)
--- FAIL: TestServerReaderFromOrder/h2 (0.80s)
testing.go:1446: race detected during execution of test
2023-02-10 22:09 darwin-amd64-race go@5c5f8dc9 net/http.TestCloseNotifierPipelined (log)
--- FAIL: TestCloseNotifierPipelined (0.01s)
2023-02-10 22:09 darwin-amd64-race go@5c5f8dc9 net/http.TestClientWriteShutdown (log)
--- FAIL: TestClientWriteShutdown (0.00s)
2023-02-10 22:09 darwin-amd64-race go@5c5f8dc9 net/http.TestServerGracefulClose (log)
--- FAIL: TestServerGracefulClose (0.00s)
--- FAIL: TestServerGracefulClose/h1 (1.55s)
testing.go:1446: race detected during execution of test
2023-02-10 22:09 linux-amd64-longtest-race go@5c5f8dc9 net/http.TestIssue4191_InfiniteGetTimeout (log)
==================
WARNING: DATA RACE
Write at 0x00c000ed4000 by goroutine 23193:
io.copyBuffer()
/workdir/go/src/io/io.go:436 +0x386
io.Copy()
/workdir/go/src/io/io.go:387 +0x57
net/http_test.testIssue4191_InfiniteGetTimeout.func1()
/workdir/go/src/net/http/transport_test.go:2229 +0x13
net/http.HandlerFunc.ServeHTTP()
...
/workdir/go/src/net/http/h2_bundle.go:4128 +0x11e
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1903 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3089 +0x4f
==================
--- FAIL: TestIssue4191_InfiniteGetTimeout (0.05s)
--- FAIL: TestIssue4191_InfiniteGetTimeout/h2 (0.04s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
2023-02-11 09:26 darwin-amd64-race go@e03ee85e net/http.TestTransportAndServerSharedBodyRace (log)
==================
WARNING: DATA RACE
Read at 0x00c000a04000 by goroutine 3270:
runtime.slicecopy()
/tmp/buildlet/go/src/runtime/slice.go:310 +0x0
net/http.(*http2Framer).WriteDataPadded()
/tmp/buildlet/go/src/net/http/h2_bundle.go:2093 +0x4dc
net/http.(*http2Framer).WriteData()
/tmp/buildlet/go/src/net/http/h2_bundle.go:2053 +0xdc
net/http.(*http2writeData).writeFrame()
...
net/http.Handler.ServeHTTP-fm()
<autogenerated>:1 +0x67
net/http.(*http2serverConn).runHandler()
/tmp/buildlet/go/src/net/http/h2_bundle.go:6111 +0xe1
net/http.(*http2serverConn).processHeaders.func1()
/tmp/buildlet/go/src/net/http/h2_bundle.go:5825 +0x5d
==================
--- FAIL: TestTransportAndServerSharedBodyRace (0.00s)
--- FAIL: TestTransportAndServerSharedBodyRace/h2 (1.63s)
testing.go:1446: race detected during execution of test
2023-02-11 09:26 darwin-amd64-race go@e03ee85e net/http.TestCloseNotifier (log)
--- FAIL: TestCloseNotifier (0.00s)
2023-02-11 09:26 darwin-amd64-race go@e03ee85e net/http.TestContentLengthZero (log)
--- FAIL: TestContentLengthZero (0.00s)
2023-02-11 09:26 darwin-amd64-race go@e03ee85e net/http.TestHijackBeforeRequestBodyRead (log)
--- FAIL: TestHijackBeforeRequestBodyRead (0.00s)
--- FAIL: TestHijackBeforeRequestBodyRead/h1 (0.23s)
testing.go:1446: race detected during execution of test
2023-02-11 09:26 darwin-amd64-race go@e03ee85e net/http.TestServerReaderFromOrder (log)
--- FAIL: TestServerReaderFromOrder (0.00s)
--- FAIL: TestServerReaderFromOrder/h1 (0.76s)
testing.go:1446: race detected during execution of test
2023-02-11 16:16 darwin-amd64-race go@261fe25c net/http.TestTransportClosesRequestBody (log)
==================
WARNING: DATA RACE
Write at 0x00c000b8c000 by goroutine 7417:
io.copyBuffer()
/tmp/buildlet/go/src/io/io.go:436 +0x386
io.Copy()
/tmp/buildlet/go/src/io/io.go:387 +0xce
io.CopyN()
/tmp/buildlet/go/src/io/io.go:363 +0xb0
net/http_test.testTransportAndServerSharedBodyRace.func2.1()
...
net/http.(*http2Server).ServeConn()
/tmp/buildlet/go/src/net/http/h2_bundle.go:4338 +0x17dd
net/http.http2ConfigureServer.func1()
/tmp/buildlet/go/src/net/http/h2_bundle.go:4128 +0x11e
net/http.(*conn).serve()
/tmp/buildlet/go/src/net/http/server.go:1903 +0x1c01
net/http.(*Server).Serve.func3()
/tmp/buildlet/go/src/net/http/server.go:3089 +0x4f
==================
--- FAIL: TestTransportClosesRequestBody (0.01s)
2023-02-11 16:16 darwin-amd64-race go@261fe25c net/http.TestTransportFlushesRequestHeader (log)
--- FAIL: TestTransportFlushesRequestHeader (0.00s)
--- FAIL: TestTransportFlushesRequestHeader/h2 (0.09s)
testing.go:1446: race detected during execution of test
--- FAIL: TestTransportFlushesRequestHeader/h1 (0.11s)
testing.go:1446: race detected during execution of test
2023-02-11 16:16 darwin-amd64-race go@261fe25c net/http.TestTransportAndServerSharedBodyRace (log)
--- FAIL: TestTransportAndServerSharedBodyRace (0.00s)
--- FAIL: TestTransportAndServerSharedBodyRace/h1 (0.39s)
testing.go:1446: race detected during execution of test
--- FAIL: TestTransportAndServerSharedBodyRace/h2 (0.38s)
testing.go:1446: race detected during execution of test
2023-02-11 16:16 darwin-amd64-race go@261fe25c net/http.TestServerRequestContextCancel_ConnClose (log)
--- FAIL: TestServerRequestContextCancel_ConnClose (0.00s)
2023-02-11 16:16 darwin-amd64-race go@261fe25c net/http.TestTransportRejectsSignInContentLength (log)
--- FAIL: TestTransportRejectsSignInContentLength (0.00s)
2023-02-13 19:16 darwin-amd64-race go@505325cf net/http.TestConnContextNotModifyingAllContexts (log)
==================
WARNING: DATA RACE
Write at 0x00c000b98000 by goroutine 16431:
io.copyBuffer()
/tmp/buildlet/go/src/io/io.go:436 +0x386
io.Copy()
/tmp/buildlet/go/src/io/io.go:387 +0x57
net/http_test.testIssue4191_InfiniteGetTimeout.func1()
/tmp/buildlet/go/src/net/http/transport_test.go:2229 +0x13
net/http.HandlerFunc.ServeHTTP()
...
/tmp/buildlet/go/src/net/http/h2_bundle.go:4128 +0x11e
net/http.(*conn).serve()
/tmp/buildlet/go/src/net/http/server.go:1903 +0x1c01
net/http.(*Server).Serve.func3()
/tmp/buildlet/go/src/net/http/server.go:3089 +0x4f
==================
--- FAIL: TestConnContextNotModifyingAllContexts (0.01s)
--- FAIL: TestConnContextNotModifyingAllContexts/h1 (0.08s)
--- FAIL: TestConnContextNotModifyingAllContexts/h2 (0.09s)
testing.go:1446: race detected during execution of test
2023-02-13 19:16 darwin-amd64-race go@505325cf net/http.TestIssue4191_InfiniteGetTimeout (log)
--- FAIL: TestIssue4191_InfiniteGetTimeout (0.00s)
--- FAIL: TestIssue4191_InfiniteGetTimeout/h1 (0.06s)
testing.go:1446: race detected during execution of test
2023-02-13 19:16 darwin-amd64-race go@505325cf net/http.TestTransportProxyConnectHeader (log)
--- FAIL: TestTransportProxyConnectHeader (0.00s)
2023-02-13 19:16 darwin-amd64-race go@505325cf net/http.TestServerShutdown (log)
--- FAIL: TestServerShutdown (0.00s)
2023-02-13 19:16 darwin-amd64-race go@505325cf net/http.TestTransportRequestWriteRoundTrip (log)
--- FAIL: TestTransportRequestWriteRoundTrip (0.00s)
--- FAIL: TestTransportRequestWriteRoundTrip/h2 (0.36s)
--- FAIL: TestTransportRequestWriteRoundTrip/h2/buffer,_no_length (0.12s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
--- FAIL: TestTransportRequestWriteRoundTrip/h1 (0.38s)
--- FAIL: TestTransportRequestWriteRoundTrip/h1/buffer (0.06s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
2023-02-13 19:16 linux-amd64-longtest-race go@505325cf net/http.TestTransportAndServerSharedBodyRace (log)
==================
WARNING: DATA RACE
Write at 0x00c00043e000 by goroutine 14162:
io.copyBuffer()
/workdir/go/src/io/io.go:436 +0x386
io.Copy()
/workdir/go/src/io/io.go:387 +0xce
io.CopyN()
/workdir/go/src/io/io.go:363 +0xb0
net/http_test.testTransportAndServerSharedBodyRace.func2.1()
...
--- FAIL: TestTransportAndServerSharedBodyRace (0.63s)
--- FAIL: TestTransportAndServerSharedBodyRace/h2 (0.09s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
==================
WARNING: DATA RACE
Write at 0x00c000440000 by goroutine 23197:
io.copyBuffer()
/workdir/go/src/io/io.go:436 +0x386
io.Copy()
...
/workdir/go/src/net/http/h2_bundle.go:4751 +0x142b
net/http.(*http2Server).ServeConn()
/workdir/go/src/net/http/h2_bundle.go:4338 +0x17dd
net/http.http2ConfigureServer.func1()
/workdir/go/src/net/http/h2_bundle.go:4128 +0x11e
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1903 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3089 +0x4f
==================
2023-02-13 19:16 linux-amd64-longtest-race go@505325cf net/http.TestIssue4191_InfiniteGetTimeout (log)
--- FAIL: TestIssue4191_InfiniteGetTimeout (0.04s)
--- FAIL: TestIssue4191_InfiniteGetTimeout/h2 (0.03s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
2023-02-13 19:16 linux-amd64-race go@505325cf net/http.TestClientTimeoutKillsConn_BeforeHeaders (log)
==================
WARNING: DATA RACE
Write at 0x00c001f0a000 by goroutine 4842:
io.copyBuffer()
/workdir/go/src/io/io.go:436 +0x386
io.Copy()
/workdir/go/src/io/io.go:387 +0xce
io.CopyN()
/workdir/go/src/io/io.go:363 +0xb0
net/http_test.testTransportAndServerSharedBodyRace.func2.1()
...
net/http.http2ConfigureServer.func1()
/workdir/go/src/net/http/h2_bundle.go:4128 +0x11e
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1903 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3089 +0x4f
==================
--- FAIL: TestClientTimeoutKillsConn_BeforeHeaders (0.00s)
--- FAIL: TestClientTimeoutKillsConn_BeforeHeaders/h1 (0.07s)
testing.go:1446: race detected during execution of test
2023-02-13 19:16 linux-amd64-race go@505325cf net/http.TestTransportAndServerSharedBodyRace (log)
--- FAIL: TestTransportAndServerSharedBodyRace (0.00s)
--- FAIL: TestTransportAndServerSharedBodyRace/h1 (0.37s)
testing.go:1446: race detected during execution of test
--- FAIL: TestTransportAndServerSharedBodyRace/h2 (0.35s)
testing.go:1446: race detected during execution of test
2023-02-13 19:16 linux-amd64-race go@505325cf net/http.TestHijackBeforeRequestBodyRead (log)
--- FAIL: TestHijackBeforeRequestBodyRead (0.00s)
--- FAIL: TestHijackBeforeRequestBodyRead/h1 (0.44s)
testing.go:1446: race detected during execution of test
2023-02-13 19:16 linux-amd64-race go@505325cf net/http.TestServerValidatesHeaders (log)
--- FAIL: TestServerValidatesHeaders (1.14s)
testing.go:1446: race detected during execution of test
2023-02-13 19:16 linux-amd64-race go@505325cf net/http.TestServerReaderFromOrder (log)
--- FAIL: TestServerReaderFromOrder (0.00s)
--- FAIL: TestServerReaderFromOrder/h1 (0.48s)
testing.go:1446: race detected during execution of test
2023-02-13 19:21 linux-amd64-longtest-race go@712c009c net/http.TestIssue4191_InfiniteGetTimeout (log)
==================
WARNING: DATA RACE
Write at 0x00c0004da000 by goroutine 23477:
io.copyBuffer()
/workdir/go/src/io/io.go:436 +0x386
io.Copy()
/workdir/go/src/io/io.go:387 +0x57
net/http_test.testIssue4191_InfiniteGetTimeout.func1()
/workdir/go/src/net/http/transport_test.go:2229 +0x13
net/http.HandlerFunc.ServeHTTP()
...
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1903 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3089 +0x4f
==================
--- FAIL: TestIssue4191_InfiniteGetTimeout (0.04s)
--- FAIL: TestIssue4191_InfiniteGetTimeout/h2 (0.03s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
2023/02/13 19:50:54 Unsolicited response received on idle HTTP channel starting with "HTTP/1.1 204 No Content\r\nConnection: close\r\n\r\n"; err=<nil>
2023-02-13 19:21 linux-amd64-race go@712c009c net/http.TestIssue4191_InfiniteGetToPutTimeout (log)
==================
WARNING: DATA RACE
Write at 0x00c000664000 by goroutine 7569:
io.copyBuffer()
/workdir/go/src/io/io.go:436 +0x386
io.Copy()
/workdir/go/src/io/io.go:387 +0x57
net/http_test.testIssue4191_InfiniteGetTimeout.func1()
/workdir/go/src/net/http/transport_test.go:2229 +0x13
net/http.HandlerFunc.ServeHTTP()
...
net/http.http2ConfigureServer.func1()
/workdir/go/src/net/http/h2_bundle.go:4128 +0x11e
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1903 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3089 +0x4f
==================
--- FAIL: TestIssue4191_InfiniteGetToPutTimeout (0.00s)
--- FAIL: TestIssue4191_InfiniteGetToPutTimeout/h1 (0.14s)
testing.go:1446: race detected during execution of test
2023-02-13 19:21 linux-amd64-race go@712c009c net/http.TestIssue4191_InfiniteGetTimeout (log)
--- FAIL: TestIssue4191_InfiniteGetTimeout (0.00s)
--- FAIL: TestIssue4191_InfiniteGetTimeout/h2 (0.07s)
testing.go:1446: race detected during execution of test
2023-02-13 19:21 linux-amd64-race go@712c009c net/http.TestFileServerNotDirError (log)
--- FAIL: TestFileServerNotDirError (0.00s)
--- FAIL: TestFileServerNotDirError/h1 (0.10s)
--- FAIL: TestFileServerNotDirError/h1/FS (0.06s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
--- FAIL: TestFileServerNotDirError/h2 (0.12s)
--- FAIL: TestFileServerNotDirError/h2/FS (0.07s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
2023-02-13 19:21 linux-amd64-race go@712c009c net/http.TestServeFile (log)
--- FAIL: TestServeFile (0.00s)
--- FAIL: TestServeFile/h1 (0.08s)
testing.go:1446: race detected during execution of test
--- FAIL: TestServeFile/h2 (0.09s)
testing.go:1446: race detected during execution of test
2023-02-13 19:21 linux-amd64-race go@712c009c net/http.TestEarlyHintsRequest (log)
--- FAIL: TestEarlyHintsRequest (0.00s)
2023-02-13 19:42 darwin-amd64-race go@0b922bfa net/http.TestTransportAndServerSharedBodyRace (log)
==================
WARNING: DATA RACE
Write at 0x00c000a3c000 by goroutine 3462:
io.copyBuffer()
/tmp/buildlet/go/src/io/io.go:436 +0x386
io.Copy()
/tmp/buildlet/go/src/io/io.go:387 +0xce
io.CopyN()
/tmp/buildlet/go/src/io/io.go:363 +0xb0
net/http_test.testTransportAndServerSharedBodyRace.func2.1()
...
net/http.(*conn).serve()
/tmp/buildlet/go/src/net/http/server.go:1903 +0x1c01
net/http.(*Server).Serve.func3()
/tmp/buildlet/go/src/net/http/server.go:3089 +0x4f
==================
--- FAIL: TestTransportAndServerSharedBodyRace (0.01s)
--- FAIL: TestTransportAndServerSharedBodyRace/h2 (0.78s)
testing.go:1446: race detected during execution of test
--- FAIL: TestTransportAndServerSharedBodyRace/h1 (1.07s)
testing.go:1446: race detected during execution of test
2023-02-13 19:42 darwin-amd64-race go@0b922bfa net/http.TestContentTypeWithVariousSources (log)
--- FAIL: TestContentTypeWithVariousSources (0.09s)
--- FAIL: TestContentTypeWithVariousSources/h2 (1.14s)
--- FAIL: TestContentTypeWithVariousSources/h2/copy_one_byte_at_a_time (0.25s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
--- FAIL: TestContentTypeWithVariousSources/h1 (1.41s)
--- FAIL: TestContentTypeWithVariousSources/h1/copy_one_byte_at_a_time (0.27s)
testing.go:1446: race detected during execution of test
testing.go:1446: race detected during execution of test
2023-02-13 19:42 darwin-amd64-race go@0b922bfa net/http.TestNoContentLengthIfTransferEncoding (log)
--- FAIL: TestNoContentLengthIfTransferEncoding (0.00s)
2023-02-13 19:42 darwin-amd64-race go@0b922bfa net/http.TestTransportRangeAndGzip (log)
--- FAIL: TestTransportRangeAndGzip (0.00s)
2023-02-13 19:42 darwin-amd64-race go@0b922bfa net/http.TestClientTimeoutKillsConn_BeforeHeaders (log)
--- FAIL: TestClientTimeoutKillsConn_BeforeHeaders (0.00s)
2023-02-13 19:42 freebsd-amd64-race go@0b922bfa net/http.TestServeFileFromCWD (log)
==================
WARNING: DATA RACE
Write at 0x00c000a74000 by goroutine 9015:
io.copyBuffer()
/tmp/workdir/go/src/io/io.go:436 +0x386
io.Copy()
/tmp/workdir/go/src/io/io.go:387 +0xce
io.CopyN()
/tmp/workdir/go/src/io/io.go:363 +0xb0
net/http.serveContent()
...
net/http.http2ConfigureServer.func1()
/tmp/workdir/go/src/net/http/h2_bundle.go:4128 +0x11e
net/http.(*conn).serve()
/tmp/workdir/go/src/net/http/server.go:1903 +0x1c01
net/http.(*Server).Serve.func3()
/tmp/workdir/go/src/net/http/server.go:3089 +0x4f
==================
--- FAIL: TestServeFileFromCWD (0.00s)
--- FAIL: TestServeFileFromCWD/h1 (0.05s)
testing.go:1446: race detected during execution of test
2023-02-13 19:42 freebsd-amd64-race go@0b922bfa net/http.TestEarlyHintsRequest (log)
--- FAIL: TestEarlyHintsRequest (0.00s)
--- FAIL: TestEarlyHintsRequest/h2 (0.05s)
testing.go:1446: race detected during execution of test
--- FAIL: TestEarlyHintsRequest/h1 (0.05s)
testing.go:1446: race detected during execution of test
2023-02-13 19:42 freebsd-amd64-race go@0b922bfa net/http.TestBadResponseAfterReadingBody (log)
--- FAIL: TestBadResponseAfterReadingBody (0.00s)
2023-02-13 19:42 freebsd-amd64-race go@0b922bfa net/http.TestWriteHeaderNoCodeCheck (log)
--- FAIL: TestWriteHeaderNoCodeCheck (0.00s)
--- FAIL: TestWriteHeaderNoCodeCheck/h1 (0.04s)
testing.go:1446: race detected during execution of test
--- FAIL: TestWriteHeaderNoCodeCheck/h2 (0.05s)
testing.go:1446: race detected during execution of test
2023-02-13 19:42 freebsd-amd64-race go@0b922bfa net/http.TestWriteHeader0 (log)
--- FAIL: TestWriteHeader0 (0.00s)
2023-02-13 19:42 linux-amd64-race go@0b922bfa net/http.TestTransportAndServerSharedBodyRace (log)
==================
WARNING: DATA RACE
Write at 0x00c001274000 by goroutine 3352:
io.copyBuffer()
/workdir/go/src/io/io.go:436 +0x386
io.Copy()
/workdir/go/src/io/io.go:387 +0xce
io.CopyN()
/workdir/go/src/io/io.go:363 +0xb0
net/http_test.testTransportAndServerSharedBodyRace.func2.1()
...
net/http.http2ConfigureServer.func1()
/workdir/go/src/net/http/h2_bundle.go:4128 +0x11e
net/http.(*conn).serve()
/workdir/go/src/net/http/server.go:1903 +0x1c01
net/http.(*Server).Serve.func3()
/workdir/go/src/net/http/server.go:3089 +0x4f
==================
--- FAIL: TestTransportAndServerSharedBodyRace (0.00s)
--- FAIL: TestTransportAndServerSharedBodyRace/h2 (0.25s)
testing.go:1446: race detected during execution of test
2023-02-13 19:42 linux-amd64-race go@0b922bfa net/http.TestH12_HeadContentLengthLargeBody (log)
--- FAIL: TestH12_HeadContentLengthLargeBody (0.12s)
testing.go:1446: race detected during execution of test
2023-02-13 19:42 linux-amd64-race go@0b922bfa net/http.TestH12_Head_ExplicitLen (log)
--- FAIL: TestH12_Head_ExplicitLen (0.06s)
testing.go:1446: race detected during execution of test
2023-02-13 19:42 linux-amd64-race go@0b922bfa net/http.TestH12_ExplicitContentLength (log)
--- FAIL: TestH12_ExplicitContentLength (0.05s)
testing.go:1446: race detected during execution of test
2023-02-13 19:42 linux-amd64-race go@0b922bfa net/http.TestH12_RequestContentLength_Known_Zero (log)
--- FAIL: TestH12_RequestContentLength_Known_Zero (0.06s)
testing.go:1446: race detected during execution of test