Neetha John

Results 20 comments of Neetha John

@volodymyrsamotiy , I think these unit tests are not sufficient to ensure that pfcwd feature is working correctly for asym mode and in combined mode. I am concerned that there...

> @neethajohn do you have additional comments or you can sign off? @liat-grozovik , I don't see my comments regarding vs tests addressed. In the last review I did, there...

@wendani , FYI, https://github.com/Azure/sonic-swss/pull/1360 changes the signature of setPortPfc and getPortPfc methods

> > @wendani , FYI, #1360 changes the signature of setPortPfc and getPortPfc methods > > What is your plan to move forward? That PR needs some rework. so you...

Please add unit tests. Refer tests/test_watermark.py

Tested with 202305 on backend and non backend testbed and tests have passed ![image](https://github.com/sonic-net/sonic-mgmt/assets/48968228/bdd8b8f6-2f40-4918-8847-3a1c6103ed63) ![image](https://github.com/sonic-net/sonic-mgmt/assets/48968228/b418d914-0911-4d8c-9e97-a881b2f93a76)