sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

Fix fixture invocation order in qos/qos_sai_base.py

Open vivekverma-arista opened this issue 11 months ago • 1 comments

Description of PR

Summary: Fix fixture invocation order in qos/qos_sai_base.py Fixes # (issue)

Type of change

  • [ ] Bug fix
  • [ ] Testbed and Framework(new/improvement)
  • [x] Test case(new/improvement)

Back port request

  • [ ] 201911
  • [ ] 202012
  • [ ] 202205
  • [ ] 202305
  • [x] 202311

Approach

What is the motivation for this PR?

qos/test_qos_sai.py fail with the following -

failed on setup with "Failed: Not all critical processes are healthy"

The fixture dut_disable_ipv6 disables ipv6 due to which the following critical processes don't come up after swapping syncd ( fixture swapSyncd_on_selected_duts ) -

  1. program:snmpd
  2. program:snmp-subagent

And this issue only hits if swapSyncd_on_selected_duts is executed after dut_disable_ipv6 and since there is no dependency between these fixtures, they can execute in any order.

How did you do it?

This change introduces a dependency between dut_disable_ipv6 & swapSyncd_on_selected_duts such that former is always executed after latter.

How did you verify/test it?

Tested on Arista-7050CX3 platform with dualtor topology.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

vivekverma-arista avatar Mar 25 '24 13:03 vivekverma-arista

hi @neethajohn @XuChen-MSFT could you help to review?

StormLiangMS avatar Apr 10 '24 12:04 StormLiangMS

@XuChen-MSFT , please take a look

neethajohn avatar Apr 17 '24 16:04 neethajohn

hi @vivekverma-arista could you run test with 202311 image?

StormLiangMS avatar Apr 18 '24 03:04 StormLiangMS

hi @vivekverma-arista could you run test with 202311 image?

Hi @StormLiangMS I have tested with 202311 image. The test passes and no new regression is seen because of this fix.

vivekverma-arista avatar Apr 22 '24 06:04 vivekverma-arista

Cherry-pick PR to 202311: https://github.com/sonic-net/sonic-mgmt/pull/12596

mssonicbld avatar Apr 26 '24 02:04 mssonicbld