Nedim Salkić

Results 127 comments of Nedim Salkić

Converting this to draft because I can get the flaky test to fail here as well, it doesn't need to be merged.

The problem is not showing up in our flaky test suite anymore and I cannot reproduce it when repeating the flaky test 100 times, which makes me confident enough that...

> Would a command for adding a new wallet be helpful? [...] Seems to me that this could be a nice extension of [forc-wallet](https://docs.fuel.network/guides/installation/#setting-up-a-local-wallet), the workflow being similar to what...

> I haven't thought much about having the file as part of the template, but that could reduce the abstraction around everything. Especially considering it contains required configs, maybe we...

I fixed this issue by setting `esbuild`'s target to `es2022`: ```ts import { defineConfig } from 'vitest/config'; export default defineConfig({ esbuild: { target: 'es2022' }, }); ```

@arboleya yes, if we're going to make the cache static then we should make the TTL setter static as well. ```ts public class Provider { static cache?: ResourceCache = new...

@Torres-ssf Regarding the cache being public, I know that you had some reasoning behind it but I can't remember it... What was it?

So this PR is going to be merged into `master` once #2782 is merged? If that's the case, I'd remove the release note description from the body of the PR...

An additional problem here is that we'll have devnet/testnet/mainnet, which will be different versions of `fuel-core` (and possibly `forc`), so we'll have to run the e2e tests with sdk versions...