fuels-ts icon indicating copy to clipboard operation
fuels-ts copied to clipboard

chore: refactor helpers related to transaction operations

Open maschad opened this issue 1 year ago • 2 comments

  • Closes https://github.com/FuelLabs/fuels-ts/issues/2835

Summary

I've put these changes on a separate branch so that https://github.com/FuelLabs/fuels-ts/pull/2782 is not blocked by this, but they are related to that pr and require the fixes suggested in that PR. I decided to do this refactor since I was already addressing a bug fix related to those operations.

Checklist

  • [ ] I addedtests to prove my changes
  • [ ] I updated — all the necessary docs
  • [x] I reviewed — the entire PR myself, using the GitHub UI
  • [ ] I described — all breaking changes and the Migration Guide

maschad avatar Jul 25 '24 21:07 maschad

So this PR is going to be merged into master once #2782 is merged? If that's the case, I'd remove the release note description from the body of the PR because refactoring in and of itself isn't worthy of mention.

In this release, we:

  • Refactored some helper functions directly related to transaction summary operations

nedsalk avatar Jul 29 '24 08:07 nedsalk

Coverage Report:

Lines Branches Functions Statements
79.76%(+0%) 72.12%(+0%) 77.81%(+0.08%) 79.9%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 89.05%
(+0%)
78.26%
(-1.45%)
85.71%
(+0%)
89.28%
(+0%)
🔴 packages/account/src/providers/transaction-summary/operations.ts 95.45%
(-0.04%)
73.68%
(+1.76%)
93.47%
(+0.97%)
94.06%
(-0.1%)
✨ packages/account/src/test-utils/test-asset-id.ts 100%
(+100%)
100%
(+100%)
100%
(+100%)
100%
(+100%)

github-actions[bot] avatar Aug 12 '24 14:08 github-actions[bot]