Neil Mitchell

Results 1198 comments of Neil Mitchell

It seems like internally we use Bxl as a wrapper that takes the `compilation-database` target, turns the paths to absolute, and then uses that for `clangd`. A bit fiddly, but...

Certainly, have assigned you @AryanBagade

CC @JakobDegen - I believe https://github.com/facebook/buck2/commit/b8c3ebaa8aede66107e73db3a7113f08456e2a11#diff-bc4913d026ae51bef2bc8b7a1c040fdf52b999d99e6fa40d87b379f98a60e0ea was meant to make this work. But doesn't in practice. This is a bit of a shame as its linked from https://engineering.fb.com/2023/04/06/open-source/buck2-open-source-large-scale-build-system/

Do you know what the FD limits are on your system? I'm not sure how many download rules we try and execute it parallel - it might be inadvertently more...

Looking at trying to fix this in #444 (needs rework, but just seeing if that concept works)

When I ran into this, I limited the number of downloads, and the problem with file descriptors showed up in writes (I think by queueing the downloads I left more...

What's the use case? Generally there's not much use in the "root" directory - Shake has `takeDirectory1` because it assumes relative file paths and build-system style operations, which are less...

So the one that works on relative paths only? It's arguable that if `takeDirectory1` is useful outside build systems it should be renamed to something sensible and moved over. What...

OK, so I'm open to adding these functions. You assumedly want: ``` takeFirstDirectory :: FilePath -> FilePath dropFirstDirectory :: FilePath -> FilePath ``` What name should they have? What should...

Thanks for the suggestions - we'll take a look in a bit, when the CI pipeline isn't changing as much. I'd expect 5-15% improvement from these changes.