Neil Mitchell comments

Results 1198 comments of


                                            Neil Mitchell

Add hints to use comparing

I think we actually had these hints in the past. But it seems not everyone is convinced by comparing - now the only instances are when you are already using...

[Discussion - PyCon] Pyrefly onboarding UX

I like the ideas behind this! We already have `pyrefly init` which is meant to be the start of this process. CC @MaggieMoss who has been driving our onboarding experience.

Update is not handled well with empty dict type inference

I think this is intentional. When you write `{}` without any type signature, we finalise the type on the first usage, which is the first argument to `update`. You can...

Update is not handled well with empty dict type inference

Indeed, the type of update is: ```python class MutableMapping(Mapping[_KT, _VT]): def update(self, **kwargs: _VT) -> None: ... ``` So nothing about this type signature demands that _KT must be `str`....

Update is not handled well with empty dict type inference

https://github.com/python/typeshed/pull/14099 for the typeshed PR.

Update is not handled well with empty dict type inference

a2559c858086214196c5b39c16b6ace312cc14be updates typeshed, which means that we are getting closer here, with better errors. But I don't think we're yet correct in all cases.

Fix minor typo in the README.md

Thanks very much - appreciate it!

Error installing from source

Yes, and we have a file https://github.com/facebook/pyrefly/blob/main/pyrefly/rust-toolchain that ensures we get the right version. Not sure why it wasn't being picked up for you.

Error installing from source

What do you get for: ``` $ rustup --version rustup 1.28.1 (f9edccde0 2025-03-05) ```

Error installing from source

If you are at PyCon, please drop into the Pyrefly room and I'd happily debug.