Neil Mitchell
Neil Mitchell
I think the right algorithm might be that given two types in a mutable container (A and B), if they have a non-object common supertype, we use that as the...
The logic is that when you type `functions` you are providing predicates for the banned function warning. However, you aren't enabling the banned function warning, just configuring it. So separately...
I'm really not sure. I don't think it's unreasonable for the LSP to have enough hooks that the starlark context object can do it, but build server would be "better".
Doh, I think that's a case of the command line interpretation happening at the wrong level.
I think no-loaded language is always better. I think "You can remove it" might be the clearest of all? At this point we believe it is definitely safe to remove,...
While anything in HLint can have bugs, I think we broadly have to assume it's right in the messaging, or it just gets way too confusing.
Reflecting on this further, I wonder if "Perhaps remove it" is the right balance? The perhaps turns it more into a dialog with the user - a suggestion. It doesn't...
I'm going to review the patches when I get back to work tomorrow. My guess is these patches are fine, but that adding tests/bzlmod support is probably going too far?...
My thoughts are to make the next steps (testing with Bazel, significant complexity) it's probably best to pull it out as a separate project. I don't think there's much value...
* For 1: I think we're OK with anything at the moment - although probably not as much everything as on those pages you link. * For 2: Agreed. That...