Nicolas Cuillery

Results 50 comments of Nicolas Cuillery

Hi, I can't see why the `getLabel` is unknown at first. At first sight, the directive with isolated scope has nothing to do with the problem because labels are evaluated...

node 0.12 and/or npm 3 is a clue, I suppose. I had to make the build working with recent node & npm version. Tests currently works with 0.10: https://travis-ci.org/ncuillery/angular-breadcrumb#L89

Hi, thanks for the PR. I need more information to understand the problem you solve here. Did you face a situation where the parent state params are not available when...

I can't reproduce the bug, I made a [Plunker](http://plnkr.co/edit/ajC2n4tjOYWIWQpQvDlo?p=preview) with queryparams. Here is my procedure: - Run the plunker in a separate window (blue button in the right top corner)...

(and sorry to let the issue unanswered during a long time)

Hi, thanks for the PR. I don't know about `component` but in the same PR for ui-router https://github.com/angular-ui/ui-router/pull/451 they add a `component.json` file too. Isn't it necessary here ?

Please can you add a `component.json` file with this content: ``` json { "name": "angular-breadcrumb", "version": "0.4.1", "description": "AngularJS module that generates a breadcrumb from ui-router's states", "keywords": [ "angular",...

I suppose you have in mind to translate the labels containing translate keys programmatically if the options is set to true, right ? How about using a custom template like...

@jamhall I'm not very kind of this option. I prefer keep the API simple and let users making a custom template. I think I'll make a FAQ wiki page. I...

> I keep the issue open to remember to add an entry for angular-translate integration. So don't close it please ;-)