angular-breadcrumb icon indicating copy to clipboard operation
angular-breadcrumb copied to clipboard

Add header to support commonjs package managers

Open OnkelTem opened this issue 10 years ago • 4 comments

Allows to use patterns like:

module.exports = 'myApp';
var dependencies = [
  require('angular-breadcrumb')
];
angular.module(module.exports, dependencies)
...

OnkelTem avatar Dec 06 '15 11:12 OnkelTem

Hi, thanks for the PR.

I don't know about component but in the same PR for ui-router https://github.com/angular-ui/ui-router/pull/451 they add a component.json file too. Isn't it necessary here ?

ncuillery avatar Dec 06 '15 13:12 ncuillery

Well actually I've never used component and just copy-pasted the header right from ui-router :) I just wanted to be able to include angular-breadcrumb like I do with ui-router - i.e. via require() as in the example above.

OnkelTem avatar Dec 06 '15 14:12 OnkelTem

Please can you add a component.json file with this content:

{
  "name": "angular-breadcrumb",
  "version": "0.4.1",
  "description": "AngularJS module that generates a breadcrumb from ui-router's states",
  "keywords": [
    "angular",
    "breadcrumb"
  ],
  "main": "release/angular-breadcrumb.js",
  "license": "MIT",
  "repo": "ncuillery/angular-breadcrumb"
} 

And add 'component.json' in the configuration of the plugin I use to keep the version in sync here

I suppose it will be enough for an already deprecated tool :smiley:

ncuillery avatar Dec 23 '15 13:12 ncuillery

#147 #148 #158 Seem to all be related. I have also seen grunt-umd used for wrapping at build time.

stramel avatar Sep 02 '16 00:09 stramel