Nicolas Cuillery

Results 50 comments of Nicolas Cuillery

Well I'm already using the More package (remember #6 ?) and I try to keep a lot amount of dependencies in my project, plus I have found an issue in...

My code is full of @visibleForTesting workaround occurrences (mentioned above). This feature would be really useful 🙏

When I started working with your library, I naturally tried to pass an instance of `Error` to the `createAction` and I was secretly hoping that the boolean `error` was automatically...

Sorry for the late answer. I think I understood your problem. The situation is a bit tricky and the module had never been tested to doing this... (load previous step...

Copy-paste of #97 > This is probably related to #68, I've replied to that thread with a [plunkr](http://plnkr.co/edit/Ij5qdqiKRQ5om8k1rmAX) but I guess since it has been marked answered previously, it is...

Hi, Does it fit to your needs ? https://github.com/angular-ui/ui-router/wiki#attach-custom-data-to-state-objects

Hi, As you can see in history, I lack time to maintain this module. I don't have work in progress. PR are greatly welcome :smile:

I'm not very kind of this behaviour. I will be confusing for users to not see a step in breadcrumb (is it abstract ? is the parent step overrided ?...

Hi, many thanks for the PR. At first glance, it looks good to me. I can't merge it for the moment: I need to fix tests (https://github.com/ncuillery/angular-breadcrumb/issues/135) before. Then I'll...

Hi @Krolock1, can you rebase your PR please ? Tests should be working.