Nick Bradbury

Results 89 comments of Nick Bradbury

@rachelmcr Pinging you before requesting a reviewer to verify this is tracking the same as iOS.

@rachelmcr For tracking `product_detail_loaded` for a new product, I'm wondering if we should wait until the product is published to determine whether it has linked products?

> I was just taking a closer look at this event and it doesn't seem to be triggered everywhere it should be. In my testing, we don't track events on...

> However, I'm not seeing any request being made to that endpoint. I'm not familiar with the ExPlat implementation on Android; could someone who knows more about it take a...

@ThomazFB @rachelmcr I've added the code we discussed on Slack and I've verified the call to `/wpcom/v2/experiments/0.1.0/assignments/woocommerceandroid/` is being made, however I'm not sure what to make of the response:...

> @nbradbury, I believe the data you're looking for should be returned inside the `variations` object. What's being returned as `null` there should be the variation name. That is what...

Crash is happening when stripping order metadata [here](https://github.com/wordpress-mobile/WordPress-FluxC-Android/blob/5bce27afc6c377d404c088f683451609263b71f3/plugins/woocommerce/src/main/kotlin/org/wordpress/android/fluxc/network/rest/wpcom/wc/order/StripOrderMetaData.kt#L28). Additional stack trace: ``` at org.wordpress.android.fluxc.network.rest.wpcom.wc.order.OrderMappingConst.isInternalAttribute$woocommerce_release(OrderMappingConst.kt:9) at org.wordpress.android.fluxc.network.rest.wpcom.wc.order.StripOrderMetaData$invoke$1.invoke(StripOrderMetaData.kt:30) at org.wordpress.android.fluxc.network.rest.wpcom.wc.order.StripOrderMetaData$invoke$1.invoke(StripOrderMetaData.kt:30) at org.wordpress.android.fluxc.network.rest.wpcom.wc.order.StripOrderMetaData$invoke$1.invoke(StripOrderMetaData.kt:30) at org.wordpress.android.fluxc.network.rest.wpcom.wc.order.StripOrderMetaData$invoke$1.invoke(StripOrderMetaData.kt:30) at kotlin.sequences.FilteringSequence$iterator$1.calcNext(Sequences.kt:171) at kotlin.sequences.FilteringSequence$iterator$1.hasNext(Sequences.kt:194) at kotlin.sequences.TransformingSequence$iterator$1.hasNext(Sequences.kt:214) at kotlin.sequences.FilteringSequence$iterator$1.calcNext(Sequences.kt:169)...

> always expect the worst and don't mark anything coming from the API as non-null, and use the Kotlin null safety features to filter out invalid metadata info. WDYT? That...

Well 💩 . I read somewhere that the constructor isn't called when the GSON `key` doesn't exist and was hoping a default value would fix it, but reading further I...