woocommerce-android icon indicating copy to clipboard operation
woocommerce-android copied to clipboard

Issue/7053 track linked products

Open nbradbury opened this issue 3 years ago • 4 comments
trafficstars

This PR partly addresses #7053 by adding missing tracking of linked products.

The reason for the missed tracking was that the tracking was being done on the grouped product list screen, which is bypassed when there are no linked products yet. I checked on iOS and it shows the grouped product list with a "No products yet" empty view in this situation, so I chose to match iOS.

To test:

  • Open product detail for a product that has no linked products
  • Tap "Add more details"
  • Tap "Linked products"
  • Tap "Add products"
  • Verify the grouped product list is shown with an empty view
  • Tap "Add product" and verify that connected_products_list is tracked with action: add_tapped
  • Select a product and verify that connected_products_list is tracked with `action: added

Android empty linked product list:

upsells

iOS empty linked product list:

iOS

  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

nbradbury avatar Aug 08 '22 19:08 nbradbury

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

wpmobilebot avatar Aug 08 '22 19:08 wpmobilebot

Warnings
:warning: PR is not assigned to a milestone.

Generated by :no_entry_sign: dangerJS

peril-woocommerce[bot] avatar Aug 08 '22 19:08 peril-woocommerce[bot]

@rachelmcr Pinging you before requesting a reviewer to verify this is tracking the same as iOS.

nbradbury avatar Aug 09 '22 14:08 nbradbury

@nbradbury I tested and verified this works as expected, matching the iOS tracking. Thank you! (And sorry for the delay; I missed this notification yesterday.)

rachelmcr avatar Aug 10 '22 10:08 rachelmcr