Nishant Bhasin

Results 35 comments of Nishant Bhasin

This is good to review, the tests were passing except for the export command and in the last commit, I fixed swift lint rules.

This is ready for review but we are waiting for some answers from the product side hence adding a `do not merge` label.

Got confirmation, we are good to merge. cc @yoanarios

Hi, @SimonBasca can you try it on simulator / fennec as well. The crash only happened on Firefox iOS v104 but never on Fennec. And if you have any logs...

@SimonBasca can you try in v103 / v104 and lmk if this is still happening on iPhone If you can reproduce this on Simulator then that would be really helpful...

@SimonBasca I followed the same steps on iPhone but couldn't reproduce it. Is it on iPad only? Do you have a video for iPhone as well?

@pashynskykh Does it work if you try to send the tab to all devices from the Desktop?

@pashynskykh you might be experiencing something completely different and not just related to sync tab notification. Have you tried a do a fresh install and while making sure in settings...

@SimonBasca can you confirm if the following is true or if it needs any more details a) send tab from Desktop -> iOS -> works b) send tab from iOS...