Nisheeth Barthwal

Results 29 comments of Nisheeth Barthwal

Wish I could but that PR is the first time I've written groovy code and as such do not necessarily feel confident in being an active collaborator and evaluating contributions....

#1933 fixes it but seems the project isn't maintained anymore.

> I'm having trouble running the smoke tests that are updated in this PR cc @nbaztec Here is the command: > > ``` > $ DEBUG=smoke:test-staking-rewards WSS_URL=wss://moonbeam-alpha.api.onfinality.io/public-ws npm run smoke-test...

I'll wait for https://github.com/PureStake/moonbeam/pull/1656 to get merged, since it contains the necessary `BoundedVec` `Read` implementations.

@4meta5 This change breaks the Lottery test https://github.com/PureStake/moonbeam/commit/1006872a256db7f181054f973c0064eb09cd2bd0#diff-2f6ef4e0b0dc5ffddf56d32b16ce67a6d3d64ced12d0a9eb00ec7d57189b4a16L127 I tried with reverting this change and the tests seemed to pass again. Seems the `RandomnessLotteryDemo.json` wasn't regenerated in the original PR...

@4meta5 no problemo, fixed it via https://github.com/PureStake/moonbeam/pull/1748/commits/964fe353fdcc29975159996d5811948c297f0fa8

Think this can be closed now, since we removed the `perf-test` from our code

@nanocryk It also makes sense to merge https://github.com/PureStake/moonbeam/pull/1733 before and unskip the test in #1734

> Should we provide a function to list the proxies for a given address, like substrate does ? I tried to achieve that functionality via providing `is_proxy` to avoid having...

> I think there is a misunderstanding here. Sustrate lists proxies by "real account", not by "proxy account.". So it can't be provided by `is_proxy` since it is the reverse...