moonbeam icon indicating copy to clipboard operation
moonbeam copied to clipboard

Published 20 hours ago • verified publisher icon moonbeam-foundation

regenerate compiled contracts

Open nbaztec opened this issue 3 years ago • 1 comments

What does it do?

Regenerates solidity contracts with new camelCase params.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

nbaztec avatar Aug 12 '22 15:08 nbaztec

We probalby need to fix ts tests for this too as a lot of them are relying on previous format

girazoki avatar Aug 12 '22 15:08 girazoki

@4meta5 This change breaks the Lottery test https://github.com/PureStake/moonbeam/commit/1006872a256db7f181054f973c0064eb09cd2bd0#diff-2f6ef4e0b0dc5ffddf56d32b16ce67a6d3d64ced12d0a9eb00ec7d57189b4a16L127 I tried with reverting this change and the tests seemed to pass again.

Seems the RandomnessLotteryDemo.json wasn't regenerated in the original PR - could you take a look please?

nbaztec avatar Aug 16 '22 12:08 nbaztec

@nbaztec feel free to revert that change https://github.com/PureStake/moonbeam/commit/1006872a256db7f181054f973c0064eb09cd2bd0#diff-2f6ef4e0b0dc5ffddf56d32b16ce67a6d3d64ced12d0a9eb00ec7d57189b4a16L127 to get the tests passing again so this PR can be merged

I'll fix it in a follow up. I don't see what I did wrong, maybe a type conversion is necessary, I tried multiplying it by 1 ether, but that did not seem to work either.

4meta5 avatar Aug 17 '22 04:08 4meta5

@4meta5 no problemo, fixed it via https://github.com/PureStake/moonbeam/pull/1748/commits/964fe353fdcc29975159996d5811948c297f0fa8

nbaztec avatar Aug 17 '22 11:08 nbaztec