Navin Chandra

Results 65 comments of Navin Chandra

I think having just `True` and `False` as supported values is more simpler and intuitive, updated the PR to support only `bool` where `False` clears the override.

> Looks like this is your test failure @shbenzer Yeah, that is flaky in the CI, locally works fine, I will check it Edit: Fixed it. In CI the order...

> I think this should all be private API. When you register a handler you specify if you need the body, and that method registers the collector and manages it...

@kurtke1990 It works perfectly fine for me with python 3.12.9: ``` ➜ python --version Python 3.12.9 ``` ``` ➜ pip install Appium-Python-Client --no-cache-dir Collecting Appium-Python-Client Downloading appium_python_client-4.5.1.tar.gz (126 kB) Preparing...

Hmm, I am also on Mac, I will try on a Windows device.

@jswitzer-lulus can you make this repo public so I can reproduce the error - https://github.com/jswitzer-lulus/cautious-garbanzo ?

@cgoldberg @titusfortner maximizing the window helped getting the page in focus. I added it for both Python and Dotnet, I don't know why its not the same with Java, Ruby....

Hi @newsgrep, there are already open PRs for implementing this feature across Python and Java. Dotnet already supports this ([PR](https://github.com/SeleniumHQ/selenium/pull/16192)). 1. Python - https://github.com/SeleniumHQ/selenium/pull/16438 2. Java - https://github.com/SeleniumHQ/selenium/pull/16336

> But in both PRs I only see `data_types=["response"]` and `DataType.RESPONSE` The `request` DataType was added recently in the bidi spec - https://github.com/w3c/webdriver-bidi/pull/1011 and the Java PR was created before...