This is an automated pull request to update pinned browsers and drivers
Merge after verify the new browser versions properly passing the tests and no bugs need to be filed
PR Compliance Guide 🔍
Below is a summary of compliance checks for this PR:
| Security Compliance |
| 🟢 | No security concerns identified
No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
|
| Ticket Compliance |
| ⚪ | 🎫 No ticket provided
|
| Codebase Duplication Compliance |
| ⚪ | Codebase context is not defined
Follow the guide to enable codebase context checks.
|
| Custom Compliance |
| 🟢 |
Generic: Meaningful Naming and Self-Documenting Code
Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting
Status: Passed
Learn more about managing compliance generic rules or creating your own custom rules
|
Generic: Secure Logging Practices
Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.
Status: Passed
Learn more about managing compliance generic rules or creating your own custom rules
|
| ⚪ |
Generic: Comprehensive Audit Trails
Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.
Status:
Not Applicable: The PR adds/updates static repository URLs and checksums without introducing runtime
actions; audit trail requirements are not applicable to these changes alone.
Referred Code
pkg_archive(
name = "mac_edge",
url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/d45a1a8b-e452-454b-8e78-5f6103c85ea4/MicrosoftEdge-143.0.3650.66.pkg",
sha256 = "a1e692f86eb5da20fe3ccad50b98755b203684fb36f9c804c30d5843ffac9677",
move = {
"MicrosoftEdge-143.0.3650.66.pkg/Payload/Microsoft Edge.app": "Edge.app",
},
build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])
exports_files(["Edge.app"])
js_library(
name = "edge-js",
data = glob(["Edge.app/**/*"]),
)
""",
)
deb_archive(
... (clipped 198 lines)
Learn more about managing compliance generic rules or creating your own custom rules
|
Generic: Robust Error Handling and Edge Case Management
Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation
Status:
No Error Handling: The new code updates URLs and SHA256 values for external archives without adding
validation or fallback handling in these snippets, and it is unclear if higher-level rules
handle download/verification failures.
Referred Code
pkg_archive(
name = "mac_edge",
url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/d45a1a8b-e452-454b-8e78-5f6103c85ea4/MicrosoftEdge-143.0.3650.66.pkg",
sha256 = "a1e692f86eb5da20fe3ccad50b98755b203684fb36f9c804c30d5843ffac9677",
move = {
"MicrosoftEdge-143.0.3650.66.pkg/Payload/Microsoft Edge.app": "Edge.app",
},
build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])
exports_files(["Edge.app"])
js_library(
name = "edge-js",
data = glob(["Edge.app/**/*"]),
)
""",
)
deb_archive(
... (clipped 198 lines)
Learn more about managing compliance generic rules or creating your own custom rules
|
Generic: Secure Error Handling
Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.
Status:
Not Applicable: These changes only adjust archive sources and checksums; no user-facing error messages are
introduced, so secure error handling cannot be evaluated from this diff.
Referred Code
pkg_archive(
name = "mac_edge",
url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/d45a1a8b-e452-454b-8e78-5f6103c85ea4/MicrosoftEdge-143.0.3650.66.pkg",
sha256 = "a1e692f86eb5da20fe3ccad50b98755b203684fb36f9c804c30d5843ffac9677",
move = {
"MicrosoftEdge-143.0.3650.66.pkg/Payload/Microsoft Edge.app": "Edge.app",
},
build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])
exports_files(["Edge.app"])
js_library(
name = "edge-js",
data = glob(["Edge.app/**/*"]),
)
""",
)
deb_archive(
... (clipped 198 lines)
Learn more about managing compliance generic rules or creating your own custom rules
|
Generic: Security-First Input Validation and Data Handling
Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities
Status:
External Sources: The code pins new external download URLs and checksums; while checksums mitigate integrity
risks, the diff does not show additional validation or trust checks beyond sha256, which
may rely on external tooling not visible here.
Referred Code
pkg_archive(
name = "mac_edge",
url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/d45a1a8b-e452-454b-8e78-5f6103c85ea4/MicrosoftEdge-143.0.3650.66.pkg",
sha256 = "a1e692f86eb5da20fe3ccad50b98755b203684fb36f9c804c30d5843ffac9677",
move = {
"MicrosoftEdge-143.0.3650.66.pkg/Payload/Microsoft Edge.app": "Edge.app",
},
build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])
exports_files(["Edge.app"])
js_library(
name = "edge-js",
data = glob(["Edge.app/**/*"]),
)
""",
)
deb_archive(
... (clipped 198 lines)
Learn more about managing compliance generic rules or creating your own custom rules
|
|
|
Compliance status legend
🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label
PR Code Suggestions ✨
No code suggestions found for the PR.
Some virtual auth tests are failing in .NET & Python for Edge (moving from 142 to 143).
Are the tests guarded differently for Edge & Chrome?
Why Python & .NET erroring and not Ruby & Java?
@cgoldberg do you have time to look at this?
That's weird. In Python, we run the same tests with Chrome and Edge.
The failures all come from trying to run this JavaScript:
driver.execute_async_script("""registerCredential({authenticatorSelection: {requireResidentKey: true}}).then(arguments[arguments.length - 1]);""")
The response that comes back is:
NotAllowedError: The operation is not allowed at this time because the page does not have focus.
Does that mean no element on the page has focus, and that's now required? We can probably force that for the tests, but I don't know if that would just be hiding a real bug in Edge.
@cgoldberg @titusfortner maximizing the window helped getting the page in focus. I added it for both Python and Dotnet, I don't know why its not the same with Java, Ruby. This only happened in CI env (maybe because of headless?), locally they were passing.
I think this is the best we can do right now, I will merge when all tests pass.
SeleniumHQ
![qodo-code-review[bot] avatar](https://avatars.githubusercontent.com/in/484649?v=4 "Published by a pub.dev verified publisher"){kind=small}
