Navin Chandra

Results 65 comments of Navin Chandra

The RBE test failures are unrelated to the changes.

Hi @GregB98, you mentioned `self.execute(Command.NEW_SESSION, caps)["value"]` in the issue title but the reproducible code doesn't include this, can you give a standalone minimal reproducible example that can be run to...

> @navin772 @Delta456 what approach did you take when implementing this? The extension related files/dirs had to be copied via bazel, which this PR is already doing. @nvborisenko I don't...

Yeah, it was the same with my implementation, I guess it's an issue with apple's RSD service.

@shbenzer thanks for the review! I have one doubt, currently the low level APIs implemented in this PR are available via the driver instance like - `driver.script.add_preload_script(js_script)`. I am planning...

> methods prepended with _ are marked as private in python but are still accessible yes, they are accessible, but I am not sure if that's a nice way to...

@shbenzer I will add the `_` prefix to make them low level API. Other option might be to add a prefix like `bidi_add_preload_script()` but since we already use `_` in...

The `//java/test/org/openqa/selenium/bidi/storage:StorageCommandsTest-edge` test is failing in the CI and recent runs on trunk which is unrelated to this PR. I tried debugging the test but it is passing locally. Probably...

> Also, do browsers support latency and download/upload throughput conditions? If so, we should add those. They will support these in the future, currently as per [spec](https://w3c.github.io/webdriver-bidi/#command-emulation-setNetworkConditions), only `offline` is...

> Change the default and type hint for `offline` to `False` (`offline=False`) Actually, the spec doesn't allows a boolean value, I added it for API simplicity, `type: "offline"` is what...