Nathan Hammond

Generate lockfile at build time.

4

When creating a production build of an application, the build should be repeatable. In order for a build to be repeatable, any dependencies and transitives should be locked. This is...

It's possible to end up with incompatible versions of node modules installed in a FastBoot build. Addon's `package.json`: ```json { "dependencies": { "@example/left-pad": "^1.2.0" }, "ember-addon": { "fastbootDependencies": [ "@example/left-pad"...

changeLocale resulting in upstream memory "leak"

5

This results in a memory "leak" inside of moment.js: https://github.com/stefanpenner/ember-moment/blob/26d8a29/addon/services/moment.js#L45 The default empty object passed in changes the invocation signature here: https://github.com/moment/moment/blob/497f918/src/lib/locale/locales.js#L119 As a consequence, each invocation to `updateLocale` creates...

Guide people toward using path resolution.

1

In a workspace setup encouraging people to directly path into `node_modules` will result in inconsistent outcomes. Instead rely on the system to properly identify the path of the node module,...

NoRootNamesError: No source files found

1

This issue is not resolved in entirety, something is dependent upon the structure of the installed files. Reduced demonstrations of failure in three separate package managers below. The errors are...

Node.js LTS Policy

39

[Rendered](https://github.com/nathanhammond/yarn-rfcs/blob/lts-policy/text/0000-lts-policy.md)

In the event of a notification that triggers reload, `this.fastboot` is possibly `undefined`: https://github.com/ember-fastboot/fastboot-app-server/blob/a5d194e4f32a06c9af42a35eefb242878d868ec2/src/worker.js#L62 `this.fastboot` comes into existence conditionally based upon: https://github.com/ember-fastboot/fastboot-app-server/blob/a5d194e4f32a06c9af42a35eefb242878d868ec2/src/worker.js#L45-L49

Workers are `started` just once: https://github.com/ember-fastboot/fastboot-app-server/blob/a5d194e4f32a06c9af42a35eefb242878d868ec2/src/fastboot-app-server.js#L53 `this.middleware` is only set here: https://github.com/ember-fastboot/fastboot-app-server/blob/a5d194e4f32a06c9af42a35eefb242878d868ec2/src/worker.js#L45-L49 And then you're stuck with that `middleware` forever: https://github.com/ember-fastboot/fastboot-app-server/blob/a5d194e4f32a06c9af42a35eefb242878d868ec2/src/worker.js#L87 For bonus points, `fastbootMiddleware` here: https://github.com/ember-fastboot/fastboot-app-server/blob/a5d194e4f32a06c9af42a35eefb242878d868ec2/src/express-http-server.js#L26 ...is therefore possibly...

Corepack on Windows inside of GitHub Actions appears to fail `prepare npm@latest --activate` the first time it is invoked _for some reason_. Subsequent calls to `prepare npm@latest --activate` (appear to)...

Combine AbsolutePath and AbsoluteSystemPath

2

`AbsolutePath` and `AbsoluteSystemPath` were representing the same thing. Now they're merged. Four commits, each mechanical: - AbsolutePath.Join => AbsolutePath.UnsafeJoin - Dump contents of absolute_path.go into absolute_system_path.go - Merging of the...