turbo icon indicating copy to clipboard operation
turbo copied to clipboard

Combine AbsolutePath and AbsoluteSystemPath

Open nathanhammond opened this issue 3 years ago • 2 comments

AbsolutePath and AbsoluteSystemPath were representing the same thing. Now they're merged.

Four commits, each mechanical:

  • AbsolutePath.Join => AbsolutePath.UnsafeJoin
  • Dump contents of absolute_path.go into absolute_system_path.go
  • Merging of the types.
  • Removal of asString, no need for an internal/external distinction for string(p). (Now calls ToString internally.)

Followups:

  • Update places where renaming symbols failed.
  • Rename to UntypedJoin
  • Removed the utility functions originally extracted and inlined them. Add comments to make linter happy.
  • Removed the log from EnsureDir. We shouldn't have this.

nathanhammond avatar Sep 21 '22 04:09 nathanhammond

@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 21 '22 04:09 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Sep 22, 2022 at 7:51PM (UTC)

vercel[bot] avatar Sep 21 '22 04:09 vercel[bot]