fastboot-app-server icon indicating copy to clipboard operation
fastboot-app-server copied to clipboard

Workers can't recover from no `distPath`.

Open nathanhammond opened this issue 6 years ago • 0 comments

Workers are started just once: https://github.com/ember-fastboot/fastboot-app-server/blob/a5d194e4f32a06c9af42a35eefb242878d868ec2/src/fastboot-app-server.js#L53

this.middleware is only set here: https://github.com/ember-fastboot/fastboot-app-server/blob/a5d194e4f32a06c9af42a35eefb242878d868ec2/src/worker.js#L45-L49

And then you're stuck with that middleware forever: https://github.com/ember-fastboot/fastboot-app-server/blob/a5d194e4f32a06c9af42a35eefb242878d868ec2/src/worker.js#L87

For bonus points, fastbootMiddleware here: https://github.com/ember-fastboot/fastboot-app-server/blob/a5d194e4f32a06c9af42a35eefb242878d868ec2/src/express-http-server.js#L26

...is therefore possibly not a FastBoot middleware which is a super troll since we expose httpServer as a downstream API.

nathanhammond avatar Feb 25 '19 23:02 nathanhammond