Nachiket Pusalkar
Nachiket Pusalkar
Please can this be reviewed soon ! thanks
Hello Good Sir @lcampanari , Could you please also address this https://github.com/jtescher/carrierwave-imageoptimizer/issues/38 in your PR? Thanks!
> @nachiket87 Are you still working on this? I feel like there will be cross over with https://github.com/basecamp/mission_control-jobs/issues/29 so maybe you should take that one too? Hello, yes I would...
> @pmareke of course! Go for it, sorry for the delay. @rosa Should I close my PR since you've assigned someone to this ticket? Here's the Pr https://github.com/basecamp/mission_control-jobs/pull/55
> This might still be worthwhile to add, nonetheless Hmm okay if you think so. You are right though, I hesitated before opening this PR because i realise it only...
@marcoroth okay, so I may have found the bug. There are two locations from where `diagnostic#validateStimulusImports` is run. This causes two diagnostics to be added. 1. https://github.com/marcoroth/stimulus-lsp/blob/27a7283941dd75d5f945d48cf228d189453aa736/server/src/server.ts#L102 2. https://github.com/marcoroth/stimulus-lsp/blob/27a7283941dd75d5f945d48cf228d189453aa736/server/src/service.ts#L59 Here...
okay upon further investigation, the issue does **not** lie in what I previously thought^ I am quite certain It is this event and the usage that is causing the issue:...
> Oh interesting, thanks for the investigation @nachiket87! > > After thinking about this a bit more, it feels like this diagnostic should anyway be part of the Stimulus Parser...
> Hey @nachiket87, FWIW, I still think this could be useful to add. Really @marcoroth ? okay, do you have any feedback on this? Sorry I didn't come back to...
added the diagnostic range for the value only in this PR: #249 @marcoroth