stimulus-lsp icon indicating copy to clipboard operation
stimulus-lsp copied to clipboard

Published 20 hours ago • verified publisher icon marcoroth

Use `keyLoc` and `valueLoc` for value definition diagnostic

Open marcoroth opened this issue 10 months ago • 1 comments

The pull request https://github.com/marcoroth/stimulus-lsp/pull/212 implemented a new stimulus.controller.value_definition.unknown_type diagnostic. Though, all diagnostics related to value definitions were targeting the whole static values values section for the diagnostic range.

Thanks to @nachiket87 we were able to add keyLoc and valueLoc to ValueDefintion in https://github.com/marcoroth/stimulus-parser/pull/102 which was released in [email protected].

We should now update the all the value definition diagnostics the Stimulus LSP has to use the newly added keyLoc and valueLoc properties to make the diagnostic ranges more accurate.

marcoroth avatar Apr 11 '24 04:04 marcoroth

added the diagnostic range for the value only in this PR: #249 @marcoroth

nachiket87 avatar Apr 11 '24 20:04 nachiket87