Ned Andreev

Results 290 comments of Ned Andreev

> Since the goal is to export `globalTestState` and related types, and move them to a separate package, this means we'd also need to export [`cmd.globalState`](https://github.com/grafana/k6/blob/24f9871266fd59d4079929c7c6d95454461049b5/cmd/root.go#L60) (since `testGlobalState` embeds it)....

> Ah I see, but these tests are lower level than `cmd` integration tests. The definition of an "integration test" is broad and fuzzy, but I see these as more...

We might also investigate a way to display the included extensions and their version in the output of `k6 version`, so we have a one-stop command we can ask users...

Yeah, it's probably high time we do this... The `Version()` method should be optional though, if it's not implemented, we can just display the extension import path or output identifier...

Thanks for opening this issue, though I am not sure this is a bug, exactly :thinking: It seems pretty clear from the code that this is actually the intended behavior:...

Ah, sorry, I apparently missed the "self closing" part of the title :man_facepalming: :coffee: I guess this might also be reason enough to add explicit XML-parsing API in k6 as...

I'll reopen this and adjust the title a bit. While k6 might follow browser conventions, I think this is something worth fixing, _probably_ by having a proper XML parsing API....

Previously discussed here: https://github.com/grafana/k6/issues/751#issuecomment-596525404 See some of my comments in that issue, they apply as much for any future WebAssembly support in k6 as they do for potentially supporting Go...

Most of this issue has been resolved by the metrics `Registry` introduced by https://github.com/grafana/k6/pull/2071 and the follow-up related PRs like https://github.com/grafana/k6/pull/2433, https://github.com/grafana/k6/pull/2442 and a bunch of refactoring PRs... However, the...

:thinking: Good points :+1: Though I am not sure if we'll be able to gracefully deprecate the current outputs without a ton of effort for https://github.com/grafana/k6/issues/1831, so maybe don't bother...