Ned Andreev

Results 290 comments of Ned Andreev

I ran the example repo on my machine and couldn't reproduce the issue :confused: First I somewhat modified the script to be able to run it with 2000 VUs on...

@ludenus can you please run your test again, but with this script: ```js var http = require('k6/http'); var check = require('k6').check; exports.options = { thresholds: { http_req_duration: ['avg < 200',...

Here they are after some formatting: ```js { "remote_ip": "172.19.0.2", "remote_port": 80, "url": "http://pong/ping/k6", "status": 200, "status_text": "200 OK", "proto": "HTTP/1.1", "headers": { "Content-Type": "application/json; charset=UTF-8", "Date": "Fri, 26 Feb...

For context, here are some similar issues we've had in the past: https://github.com/loadimpact/k6/issues/588, https://github.com/loadimpact/k6/pull/862. This time it seems like: - it's not an HTTP/2 issue, see `"proto": "HTTP/1.1"` everywhere -...

On the other hand, it doesn't look like the relevant code from the Go stdlib does anything strange, or indeed, has been changed recently :confused: https://github.com/golang/go/blame/520f3b72db7befab2028d9a47376267cf2d274a9/src/net/http/transport.go#L2265-L2270

I'm officially stumped :sweat_smile: Debugging this would be super difficult when I can't reproduce it locally, and when it happens so rarely. See the check count in https://github.com/loadimpact/k6/issues/1872#issuecomment-786519330 ``` ✗...

Thanks, @alexb-img, this sounds like a very plausible explanation for what we observed! I can't test it right now, but assuming you are right, do you have any suggestions for...

Yeah, `k6 version` can't be removed at this point, but I don't see a problem with also having `--version` for users that are used to other tools. I think that...

Sorry for the frustration with this, unfortunately you are completely right again, this is a bug. Here's a demo script that confirms it: ```js import http from "k6/http"; export default...

The reason for the issue seems to be that Go's `httputil.DumpRequestOut()` just adds that header by default, probably to emulate the way `http.DefaultTransport` [behaves](https://github.com/golang/go/blob/ba66d89d7882892f762e7980562287d2c79ad87e/src/net/http/transport.go#L182-L190). But k6 uses a [custom `http.Transport`](https://github.com/loadimpact/k6/blob/607b63c4400c8b6852c7f51a0a6151f0bb8ec6b7/js/runner.go#L162-L171),...